[DRILL-2574] SendingAccountor can suffer from lost updates

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7.0
• Fix Version/s: 0.8.0
• Component/s: Execution - RPC
• Assignee: Jacques Nadeau
• Reporter: Chris Westin
• Created: 26/Mar/15 00:52
• Updated: 01/Apr/15 21:56
• Resolved: 27/Mar/15 16:23

Description

In SendingAccountor.waitForSendToComplete():

public synchronized void waitForSendComplete() {
  try {
    wait.acquire(batchesSent.get());
    batchesSent.set(0);
  } catch (InterruptedException e) {
    logger.warn("Failure while waiting for send complete.", e);
    // TODO InterruptedException
  }
}

It's possible that between the time batchesSent.get() returns and that batchesSent.set(0) are executed, that additional batches could have been sent. If that happens, then the set(0) overwrites the count, losing those. This needs to be better protected against that.

Issue Links

• is duplicated by: DRILL-1909 Fix SendingAccountor thread safety