[DRILL-2465] Fix multiple DatabaseMetaData.getColumns() bugs (some)

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 0.9.0
• Component/s: Client - JDBC, Metadata
• Assignee: Daniel Barclay
• Reporter: Daniel Barclay
• Created: 15/Mar/15 20:13
• Updated: 02/Jun/15 22:05
• Resolved: 27/Mar/15 22:06

Description

Fixed most getColumn() bugs reported in DRILL-2420:

• Added COLUMN_SIZE (in part to move later columns to right ordinal position). [With workarounds for INFORMATION_SCHEMA.COLUMN bugs.]
• Fixed DECIMAL_DIGITS (was DECIMAL_PRECISION; didn't report values for numeric types other than DECIMAL).
• Fixed NUM_PREC_RADIX (was -1 for cases that should be NULL).
• Fixed REMARKS (from '' to NULL).
• Fixed COLUMN_DEF (from '' to NULL).
• Fixed CHARACTER_OCTET_LENGTH (was 4). [With workarounds for (possible) INFORMATION_SCHEMA.COLUMN bugs.]
• Fixed ORDINAL_POSITION (was returning 1 for every column).
• Fixed SCOPE_CATALOG (from '' to NULL).
• Fixed SCOPE_SCHEMA (from '' to NULL).
• Fixed SCOPE_TABLE (from '' to NULL).
• Fixed SOURCE_DATA_TYPE (from VARCHAR to INTEGER.) [With workaround because SMALLINT not implemented yet.]

Issue Links

• incorporates: DRILL-2450 JDBC : DatabaseMetaData.getColumns is missing the 'COLUMN_SIZE' in the result set
• is blocked by: DRILL-2503 Having many WHENs causes ClassReader.accept()/EXPAND_FRAMES error
• is blocked by: DRILL-2439 getBoolean(...) on BOOLEAN column says wrong type
• is blocked by: DRILL-2461 INFORMATION_SCHEMA's COLUMNS dies when INTERVAL ... column exists
• is blocked by: DRILL-2463 Implement JDBC mapping of SQL NULL for ResultSet.getXxx() methods
• is part of: DRILL-2420 [umbrella] Identify, fix DatabaseMetaData.getColumns() bugs
• is related to: DRILL-2470 [umbrella] Implement SMALLINT and maybe TINYINT
• is related to: DRILL-2519 INFORMATION_SCHEMA.COLUMNS is missing <interval_qualifier> info
• is related to: DRILL-2128 DatabaseMetaData.getColumns()'s DATA_TYPE has wrong type
• relates to: DRILL-2763 [umbrella] Implement INFORMATION_SCHEMA.COLUMNS enough for relevant tools
• relates to: DRILL-3216 Fix existing(+) INFORMATION_SCHEMA.COLUMNS columns