Apache Drill
  1. Apache Drill
  2. DRILL-221

Add license header to all files, enable Rat and enforcer

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0-milestone-1
    • Fix Version/s: 1.0.0-milestone-1
    • Labels:

      Description

      There are number of files that are missing license headers. These need to be fixed before release. Additionally, Rat and enforcer should be updated to automatically check this moving forward.

      http://www.apache.org/legal/src-headers.html

      http://incubator.apache.org/guides/releasemanagement.html#best-practice

      1. DRILL-221.1.patch.txt
        643 kB
        Nachiketa Mishra

        Activity

        Jacques Nadeau created issue -
        Hide
        Nachiketa Mishra added a comment -

        Patch for License Headers source files.

        Show
        Nachiketa Mishra added a comment - Patch for License Headers source files.
        Nachiketa Mishra made changes -
        Field Original Value New Value
        Attachment DRILL-221.1.patch.txt [ 12602280 ]
        Hide
        Nachiketa Mishra added a comment -

        Patch file attached.

        Show
        Nachiketa Mishra added a comment - Patch file attached.
        Nachiketa Mishra made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s M1 [ 12324669 ]
        Labels license patch
        Hide
        Timothy Chen added a comment -

        I notice you also added comments for json files, and I don't think comments are supported with json files.

        Show
        Timothy Chen added a comment - I notice you also added comments for json files, and I don't think comments are supported with json files.
        Hide
        Nachiketa Mishra added a comment -

        I can submit another patch with just java files. Should I do that?

        Show
        Nachiketa Mishra added a comment - I can submit another patch with just java files. Should I do that?
        Hide
        Steven Phillips added a comment -

        I have a patch on my repository. Link is here:

        https://github.com/StevenMPhillips/incubator-drill/commit/f3c56d13b1a9a16c6e01f38731b1f15601a07368

        I generated it using the license-maven-plugin. That handled all of the java files. I manually added the license to a few of the bash scripts.

        This patch also has the license-maven-plugin run a check as part of the build process. It will fail if there are any java files without a license header.

        Show
        Steven Phillips added a comment - I have a patch on my repository. Link is here: https://github.com/StevenMPhillips/incubator-drill/commit/f3c56d13b1a9a16c6e01f38731b1f15601a07368 I generated it using the license-maven-plugin. That handled all of the java files. I manually added the license to a few of the bash scripts. This patch also has the license-maven-plugin run a check as part of the build process. It will fail if there are any java files without a license header.
        Hide
        Nachiketa Mishra added a comment -

        I used the Copyright plugin in eclipse. I don't want to duplicate the effort if the patch by Steven is taking care of this issue.

        Show
        Nachiketa Mishra added a comment - I used the Copyright plugin in eclipse. I don't want to duplicate the effort if the patch by Steven is taking care of this issue.
        Jacques Nadeau made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee Steven Phillips [ sphillips ]
        Resolution Fixed [ 1 ]
        Jacques Nadeau made changes -
        Fix Version/s M1 [ 12324669 ]

          People

          • Assignee:
            Steven Phillips
            Reporter:
            Jacques Nadeau
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development