Apache Drill
  1. Apache Drill
  2. DRILL-1102

Use same set of keys to distribute rows when planner generates exchange for a join operator.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:
      None

      Description

      Today, planner might use a different key sets when generate hash-to-random exchange operator for a join's left and right side.

      For instance, if we have join condition :
      L1 = R1 and L2 = R2,

      Planner may generate a plan where the join's left side is hash distributed using L1, while the right side is hash distributed using (R1, R2). Such plan is not valid, since it would produce wrong query result.

      To do that, we need make sure the planner will use the same set of keys when ask for hash distribution for a join's left and right side.

        Activity

        Hide
        Jacques Nadeau added a comment -

        fixed by 790a2ad or earlier

        Show
        Jacques Nadeau added a comment - fixed by 790a2ad or earlier
        Hide
        Weiwei Hsieh added a comment -

        Hi,

        I will take a vacation from June 3rd until July 2nd. If you need assistance while I’m away, please contact my manager Paul Mansfield.

        Thanks!

        weiwei

        Show
        Weiwei Hsieh added a comment - Hi, I will take a vacation from June 3rd until July 2nd. If you need assistance while I’m away, please contact my manager Paul Mansfield. Thanks! weiwei
        Hide
        Jinfeng Ni added a comment -

        Yes, I think so. I run the smoking test (TPCH on SF1) and the automation
        test. No regression found.

        On Thu, Jul 3, 2014 at 5:43 AM, Aditya Kishore (JIRA) <jira@apache.org>

        Show
        Jinfeng Ni added a comment - Yes, I think so. I run the smoking test (TPCH on SF1) and the automation test. No regression found. On Thu, Jul 3, 2014 at 5:43 AM, Aditya Kishore (JIRA) <jira@apache.org>
        Hide
        Aditya Kishore added a comment -

        Is the patch in your branch ready for merge?

        Show
        Aditya Kishore added a comment - Is the patch in your branch ready for merge?

          People

          • Assignee:
            Unassigned
            Reporter:
            Jinfeng Ni
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development