Apache Drill
  1. Apache Drill
  2. DRILL-1084

Remove hardcoded timeout limit rule for testcases

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: Future
    • Component/s: Tools, Build & Test
    • Labels:
      None

      Description

      We have testcase timeout rule enforced in multiple places:

      @Rule public final TestRule TIMEOUT = TestTools.getTimeoutRule(50000);

      We need to increase this value for making all Tests successful.

      1. DRILL-1084.patch
        6 kB
        Yash Sharma
      2. DRILL-1084.patch
        4 kB
        Yash Sharma

        Activity

        Yash Sharma created issue -
        Yash Sharma made changes -
        Field Original Value New Value
        Attachment DRILL-1084.patch [ 12652679 ]
        Hide
        Yash Sharma added a comment -

        Increased timeout to 200000 ms.

        Show
        Yash Sharma added a comment - Increased timeout to 200000 ms.
        Hide
        Jacques Nadeau added a comment -

        Can you please rewrite this patch so this is command line configurable instead of hardcoded with the default at 50seconds. Running with a huge timeout makes the build take forever in the case of failures. To make travis work, you may also want to drop the number of surefire forks via a command line option.

        Show
        Jacques Nadeau added a comment - Can you please rewrite this patch so this is command line configurable instead of hardcoded with the default at 50seconds. Running with a huge timeout makes the build take forever in the case of failures. To make travis work, you may also want to drop the number of surefire forks via a command line option.
        Hide
        Yash Sharma added a comment - - edited

        Added new patch:

        • removing hardcoded timeout limits & added config to drill parent pom
        • enforcing forkedProcessTimeoutInSeconds: 200secs
        • enforcing parallelTestsTimeoutForcedInSeconds: 200secs
        Show
        Yash Sharma added a comment - - edited Added new patch: removing hardcoded timeout limits & added config to drill parent pom enforcing forkedProcessTimeoutInSeconds: 200secs enforcing parallelTestsTimeoutForcedInSeconds: 200secs
        Yash Sharma made changes -
        Attachment DRILL-1084.patch [ 12653004 ]
        Yash Sharma made changes -
        Priority Major [ 3 ] Minor [ 4 ]
        Yash Sharma made changes -
        Summary Increase timeout limit rule for testcases Remove hardcoded timeout limit rule for testcases
        Yash Sharma made changes -
        Assignee Yash Sharma [ yash360@gmail.com ] DrillCommitter [ drillcommitter ]
        Jacques Nadeau made changes -
        Fix Version/s 0.5.0 [ 12324880 ]
        Jacques Nadeau made changes -
        Fix Version/s 0.6.0 [ 12327472 ]
        Fix Version/s 0.5.0 [ 12324880 ]
        Jacques Nadeau made changes -
        Fix Version/s 0.7.0 [ 12327473 ]
        Fix Version/s 0.6.0 [ 12327472 ]
        Jacques Nadeau made changes -
        Fix Version/s 0.8.0 [ 12328812 ]
        Fix Version/s 0.7.0 [ 12327473 ]
        Jacques Nadeau made changes -
        Fix Version/s 0.9.0 [ 12328813 ]
        Fix Version/s 0.8.0 [ 12328812 ]
        Jacques Nadeau made changes -
        Fix Version/s Future [ 12326743 ]
        Fix Version/s 0.9.0 [ 12328813 ]
        Component/s Tools, Build & Test [ 12322692 ]
        Tony Stevenson made changes -
        Workflow no-reopen-closed, patch-avail, testing [ 12872070 ] Drill workflow [ 12934182 ]

          People

          • Assignee:
            DrillCommitter
            Reporter:
            Yash Sharma
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development