Uploaded image for project: 'Maven Doxia Sitetools'
  1. Maven Doxia Sitetools
  2. DOXIASITETOOLS-268

Don't open version resource file on every call to render

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.11.1, 2.0.0-M3
    • 2.0.0-M4, 2.0.0
    • Site renderer
    • None

    Description

      This is a big performance bug. I have 45,000 Markdown files to render, and it takes close to an hour right now in my CI/CD job.

      I realized that on every single rendering file, we are loading a resource:
      InputStream inputStream = DefaultSiteRenderer.class.getResourceAsStream( "/META-INF/"
                  + "maven/org.apache.maven.doxia/doxia-site-renderer/pom.properties" );

      If we only move this to load one time in a static initialization block, performance significantly improves.

      Change to DefaultSiteRenderer:

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            michael-o Michael Osipov
            jdimeo John Dimeo
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment