[DOXIASITETOOLS-171] DefaultSiteRenderer must use Package#getImplementationVersion to check for Doxia Sitetools prerequisite

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.3
• Fix Version/s: 1.7.4
• Component/s: Site renderer
• Assignee: Michael Osipov
• Reporter: Michael Osipov
• Created: 07/Nov/16 20:11
• Updated: 08/Nov/16 19:06
• Resolved: 08/Nov/16 18:51

Description

Issue raised on the mailing list with a sample project issue has been reproduced.

The reason is that the prerequisite for the Sitetools are validated against:

Package p = DefaultSiteRenderer.class.getPackage();
String current = ( p == null ) ? null : p.getSpecificationVersion();

but the specification for the value of SpecificationVersion is major.minor. This was broken for some years and finally fixed with MSHARED-191. This likely creeped into the module.

Proposed patch:

Index: DefaultSiteRenderer.java
===================================================================
--- DefaultSiteRenderer.java	(revision 1768577)
+++ DefaultSiteRenderer.java	(working copy)
@@ -803,7 +803,7 @@
                     skinModel.getPrerequisites() == null ? null : skinModel.getPrerequisites().getDoxiaSitetools();
 
                 Package p = DefaultSiteRenderer.class.getPackage();
-                String current = ( p == null ) ? null : p.getSpecificationVersion();
+                String current = ( p == null ) ? null : p.getImplementationVersion();
 
                 if ( StringUtils.isNotBlank( toolsPrerequisite ) && ( current != null )
                     && !matchVersion( current, toolsPrerequisite ) )

works flawlessly with the sample project.

Issue Links

• relates to: DOXIASITETOOLS-149 Create a skin descriptor to contain metadata about the skin