Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.5
    • Component/s: Module - Confluence
    • Labels:
      None
    • Environment:
      Windows/Linux
    • Flags:
      Patch

      Description

      While working on project documentation I encountered a (at least I think) bug which is related to including images in tables. The example below doesn’t result in an image shown in the table cell but instead shows the inclusion as text (Unable to render embedded object: File (images/symbol.png) not found.).

      ||Symbol||Description||
      |!images/symbol.png!|text|
      

      After investigation I found out that the renderer of the table (TableBlockParser) only applies the ParagraphBlockParser and not other parsers like SectionBlockParser, FigureBlockParser, and ListBlockParser.

      To fix this I created the included patch. With this patch applied to version 1.4 of Doxia the example as shown above was properly parsed.

        Activity

        Mark Schenk created issue -
        Hide
        Robert Scholte added a comment -

        Hi, thanks for the patch, really worth checking. Could you do me a small favour: Use the trunk instead of the tag (i.e. http://svn.apache.org/repos/asf/maven/doxia/doxia/trunk/doxia-modules/doxia-module-confluence/ ) and preserve the formatting ( see http://maven.apache.org/developers/conventions/code.html ).
        In the end we need a unittest as well to confirm the fix and to prevent regression. That's a bit tricky, so if needed I can help with that.

        Show
        Robert Scholte added a comment - Hi, thanks for the patch, really worth checking. Could you do me a small favour: Use the trunk instead of the tag (i.e. http://svn.apache.org/repos/asf/maven/doxia/doxia/trunk/doxia-modules/doxia-module-confluence/ ) and preserve the formatting ( see http://maven.apache.org/developers/conventions/code.html ). In the end we need a unittest as well to confirm the fix and to prevent regression. That's a bit tricky, so if needed I can help with that.
        Hide
        Mark Schenk added a comment -

        Added patch for trunk including unit test

        Show
        Mark Schenk added a comment - Added patch for trunk including unit test
        Mark Schenk made changes -
        Field Original Value New Value
        Attachment Patch_DOXIA-493_trunk.patch [ 63844 ]
        Robert Scholte made changes -
        Assignee Robert Scholte [ rfscholte ]
        Hide
        Robert Scholte added a comment -

        Fixed in r1509970
        Thanks for the complete patch!

        Show
        Robert Scholte added a comment - Fixed in r1509970 Thanks for the complete patch!
        Robert Scholte made changes -
        Fix Version/s 1.4.1 [ 19200 ]
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 09:30:24 UTC 2015 [ 1428226224715 ]
        Mark Thomas made changes -
        Workflow jira [ 12719896 ] Default workflow, editable Closed status [ 12748523 ]
        Mark Thomas made changes -
        Patch Submitted Yes [ 10763 ]
        Flags Patch [ 10430 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 23:17:25 UTC 2015 [ 1428275845026 ]
        Mark Thomas made changes -
        Workflow jira [ 12957339 ] Default workflow, editable Closed status [ 12994328 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        8d 4h 52m 1 Robert Scholte 03/Aug/13 07:31

          People

          • Assignee:
            Robert Scholte
            Reporter:
            Mark Schenk
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development