Maven Doxia
  1. Maven Doxia
  2. DOXIA-254

Using the last version of modello-maven-plugin

    Details

      Description

      modello-maven-plugin:1.0-alpha-21 produces errors in doxia-decoration-model project

      1. DOXIA-254
        2 kB
        Olivier Lamy (*$^¨%`£)
      2. testInheritence.diff
        2 kB
        Siveton Vincent

        Activity

        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        fixing the xsd generation with attached patch generate junit issues.

        Failed tests:
          testInheritence(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)
          testFullyPopulatedParentAndEmptyChild(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)
          testResolvingAllRelativeUrls(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)
          testResolvingAllSiteUrls(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)
          testLogoWithoutImage(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)
        
        Tests run: 49, Failures: 5, Errors: 0, Skipped: 0
        
        Show
        Olivier Lamy (*$^¨%`£) added a comment - fixing the xsd generation with attached patch generate junit issues. Failed tests: testInheritence(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest) testFullyPopulatedParentAndEmptyChild(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest) testResolvingAllRelativeUrls(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest) testResolvingAllSiteUrls(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest) testLogoWithoutImage(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest) Tests run: 49, Failures: 5, Errors: 0, Skipped: 0
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        patch which fix xsd generation

        Show
        Olivier Lamy (*$^¨%`£) added a comment - patch which fix xsd generation
        Hide
        Siveton Vincent added a comment -

        You did exactly what I did

        Show
        Siveton Vincent added a comment - You did exactly what I did
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        What has changed in modello ? (I will try a diff on generated classes)
        it looks to be a very WEIRD issue

        Show
        Olivier Lamy (*$^¨%`£) added a comment - What has changed in modello ? (I will try a diff on generated classes) it looks to be a very WEIRD issue
        Hide
        Siveton Vincent added a comment -

        The change is in MenuItem#equals(Object other) which uses also super.equals(), introduced by MODELLO-83.

        Show
        Siveton Vincent added a comment - The change is in MenuItem#equals(Object other) which uses also super.equals(), introduced by MODELLO-83.
        Hide
        Siveton Vincent added a comment -

        The tests like testInheritence() were originally wrong.

        I tried to debug the mergedModel and childModel object using Xstream. The attachment shows the Xstream differences: mainly links in childModel should be .. (dotdot) I will fix tests under latest Modello.

        Show
        Siveton Vincent added a comment - The tests like testInheritence() were originally wrong. I tried to debug the mergedModel and childModel object using Xstream. The attachment shows the Xstream differences: mainly links in childModel should be .. (dotdot) I will fix tests under latest Modello.
        Hide
        Siveton Vincent added a comment -

        fixed in r736628

        Show
        Siveton Vincent added a comment - fixed in r736628
        Hide
        Dennis Lundberg added a comment -

        Thanks for looking into this Vincent.

        I have been trying to fix this on the 1.0.x branch before I release 1.0.

        Do you think it's possible/preferable to merge r736628 to the 1.0.x branch?

        Show
        Dennis Lundberg added a comment - Thanks for looking into this Vincent. I have been trying to fix this on the 1.0.x branch before I release 1.0. Do you think it's possible/preferable to merge r736628 to the 1.0.x branch?
        Hide
        Siveton Vincent added a comment -

        Dennis, I was thinking to ping you since you are our official branch maintainer! So feel free to do it

        Show
        Siveton Vincent added a comment - Dennis, I was thinking to ping you since you are our official branch maintainer! So feel free to do it
        Hide
        Siveton Vincent added a comment -

        An other comment, FYI the generated XSD is actually wrong, but it is fixed with the modello beta-1

        Show
        Siveton Vincent added a comment - An other comment, FYI the generated XSD is actually wrong, but it is fixed with the modello beta-1
        Hide
        Dennis Lundberg added a comment -

        This issue is now fixed for the 1.0 branch as well.

        Show
        Dennis Lundberg added a comment - This issue is now fixed for the 1.0 branch as well.

          People

          • Assignee:
            Siveton Vincent
            Reporter:
            Siveton Vincent
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development