[DOXIA-221] Fix ArrayIndexOutOfBoundsException in XhtmlBaseSink

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1
• Fix Version/s: 1.1
• Component/s: Module - Xdoc
• Flags: Patch
• Assignee: Lukas Theussl
• Reporter: Benjamin Bentmann
• Created: 16/Feb/08 18:30
• Updated: 07/Apr/15 18:15
• Resolved: 17/Feb/08 01:44

Description

Attempt to render a multi column table using XDoc:

java.lang.ArrayIndexOutOfBoundsException: 1
	at org.apache.maven.doxia.sink.XhtmlBaseSink.tableCell(XhtmlBaseSink.java:807)
	at org.apache.maven.doxia.sink.XhtmlBaseSink.tableCell(XhtmlBaseSink.java:780)
	at org.apache.maven.doxia.sink.XhtmlBaseSink.tableHeaderCell(XhtmlBaseSink.java:768)
	at org.apache.maven.doxia.parser.XhtmlBaseParser.baseStartTag(XhtmlBaseParser.java:300)
	at org.apache.maven.doxia.module.xdoc.XdocParser.handleStartTag(XdocParser.java:213)
	at org.apache.maven.doxia.parser.AbstractXmlParser.parseXml(AbstractXmlParser.java:103)
	at org.apache.maven.doxia.parser.AbstractXmlParser.parse(AbstractXmlParser.java:54)
	at org.apache.maven.doxia.module.xdoc.XdocParser.parse(XdocParser.java:93)
	at org.apache.maven.doxia.DefaultDoxia.parse(DefaultDoxia.java:63)
	at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderDocument(DefaultSiteRenderer.java:345)
	at org.apache.maven.doxia.siterenderer.DoxiaDocumentRenderer.renderDocument(DoxiaDocumentRenderer.java:46)
	at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:272)
	at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:102)
	at org.apache.maven.plugins.site.SiteMojo.renderLocale(SiteMojo.java:137)
	at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:96)

The XDocParser/XHtmlBaseParser calls sink.tableRows() always with a single-element array. This is usually not enough to describe all columns of the table individually. Hence, XHtmlBaseSink should be prepared to render a table cell that does not have a corresponding cellJustif entry. The patch simply repeats the justification of the last array element.

Last but not least, it might be worth to consider changing the default cell alignment to left alignment to match the default behavior of HTML for table body cells. Additionally, left-alignment seems to be the current behavior of the xdoc module in the alpha branch.

Issue Links

• is depended upon by: MPIR-215 java.lang.ArrayIndexOutOfBoundsException: 1 - Empty POM Project
• is related to: DOXIA-385 Xdoc: tables without "align" attribute is center aligned
• is related to: DOXIA-38 Independent row parsing