Maven Doxia
  1. Maven Doxia
  2. DOXIA-170

Confluence module should do something with non-doxia formatting

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0-alpha-8
    • Fix Version/s: 1.4
    • Component/s: Module - Confluence
    • Labels:
      None

      Description

      These wiki formats are not recognised citation strikethrough underlined superscript subscript

        Activity

        Hide
        Vincent Massol added a comment -

        The strikethrough and underline ones are duplicates of DOXIA-163 and DOXIA-164

        Show
        Vincent Massol added a comment - The strikethrough and underline ones are duplicates of DOXIA-163 and DOXIA-164
        Hide
        Dave Syer added a comment -

        Strictly speaking I wouls argue that is not the case, since DOXIA-163 and DOXIA-164 are Sink API issues. I meant that the Confluence module should recognise those annotations even if it can't render them properly because of limitations in another API.

        Show
        Dave Syer added a comment - Strictly speaking I wouls argue that is not the case, since DOXIA-163 and DOXIA-164 are Sink API issues. I meant that the Confluence module should recognise those annotations even if it can't render them properly because of limitations in another API.
        Hide
        Lukas Theussl added a comment -

        Could you specify what you mean with 'do something' and 'recognize'? If the confluence parser can't emit an event to a sink, then what's the point in recognizing it? What else do you want to do with it?

        Show
        Lukas Theussl added a comment - Could you specify what you mean with 'do something' and 'recognize'? If the confluence parser can't emit an event to a sink, then what's the point in recognizing it? What else do you want to do with it?
        Hide
        Dave Syer added a comment - - edited

        I think it should render to something that is readable. In the case of citation and underline, the intention of the author was to highlight the text, so citation->italic, underline->italic/bold makes sense. Strikethrough is difficult because the intention of the author is to show something that is visible but can be ignored. Maybe a special bracket construct like [ignore]...[/ignore]? Superscript and subscript could be rendered as ^(...) and _(...).

        Show
        Dave Syer added a comment - - edited I think it should render to something that is readable. In the case of citation and underline, the intention of the author was to highlight the text, so citation->italic, underline->italic/bold makes sense. Strikethrough is difficult because the intention of the author is to show something that is visible but can be ignored. Maybe a special bracket construct like [ignore] ... [/ignore] ? Superscript and subscript could be rendered as ^(...) and _(...).
        Hide
        Lukas Theussl added a comment -

        What's happening currently with the content of these elements, are they swallowed? If yes I guess we should at least output the text content as plain text, so no information is lost.

        Show
        Lukas Theussl added a comment - What's happening currently with the content of these elements, are they swallowed? If yes I guess we should at least output the text content as plain text, so no information is lost.
        Hide
        Dave Syer added a comment -

        I imagine they are not lost as things are, but they also won't come out in HTML anything like the author intended. They will come out with the formatting characters from confluence, which might mean something to the author, but will be nonsense to the reader.

        Show
        Dave Syer added a comment - I imagine they are not lost as things are, but they also won't come out in HTML anything like the author intended. They will come out with the formatting characters from confluence, which might mean something to the author, but will be nonsense to the reader.
        Hide
        Lukas Theussl added a comment -

        OK, thanks for the clarification. I have scheduled this for a later release for now, but if anyone attaches a patch (hint!) we can incorporate this easily.

        Just bear in mind that the parser events should be consumable by any type of sink, eg I think citation->italic, underline->bold makes perfect sense, however inserting special markup might lead to trouble later, so just output plain text would be enough IMO.

        Show
        Lukas Theussl added a comment - OK, thanks for the clarification. I have scheduled this for a later release for now, but if anyone attaches a patch (hint!) we can incorporate this easily. Just bear in mind that the parser events should be consumable by any type of sink, eg I think citation->italic, underline->bold makes perfect sense, however inserting special markup might lead to trouble later, so just output plain text would be enough IMO.
        Hide
        Lukas Theussl added a comment -

        strikethrough, underlined, superscript and subscript are now supported via SinkEventAttributes, see DOXIA-163. The confluence parser just needs to be adapted to emit the correct attributes.

        Show
        Lukas Theussl added a comment - strikethrough, underlined, superscript and subscript are now supported via SinkEventAttributes, see DOXIA-163 . The confluence parser just needs to be adapted to emit the correct attributes.
        Hide
        Robert Scholte added a comment -

        Writing to confluence markup is fixed in r1465304

        Show
        Robert Scholte added a comment - Writing to confluence markup is fixed in r1465304
        Hide
        Robert Scholte added a comment -

        Reading from confluence markup is fixed in r1465353

        Show
        Robert Scholte added a comment - Reading from confluence markup is fixed in r1465353

          People

          • Assignee:
            Robert Scholte
            Reporter:
            Dave Syer
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development