[DISPATCH-986] Coverity issues on master

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.1.0
• Component/s: Container
• Assignee: Ganesh Murthy
• Reporter: Ganesh Murthy
• Created: 01/May/18 18:50
• Updated: 02/Oct/19 17:55
• Resolved: 01/May/18 18:58

Description

2 new defect(s) introduced to Apache Qpid dispatch-router found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)

• • CID 277470:  Resource leaks  (RESOURCE_LEAK)
    /home/kgiusti/work/dispatch/qpid-dispatch/src/connection_manager.c: 607 in qd_dispatch_configure_sasl_plugin()

________________________________________________________________________________________________________

• • • CID 277470:  Resource leaks  (RESOURCE_LEAK)
      /home/kgiusti/work/dispatch/qpid-dispatch/src/connection_manager.c: 607 in qd_dispatch_configure_sasl_plugin()
      601         }
      602     
      603         sasl_plugin->sasl_init_hostname         = qd_entity_opt_string(entity, "realm", 0); CHECK();
      604         sasl_plugin->auth_ssl_profile           = qd_entity_opt_string(entity, "sslProfile", 0); CHECK();
      605     
      606         qd_log(cm->log_source, QD_LOG_INFO, "Created SASL plugin config with name %s", sasl_plugin->name);
      >>>     CID 277470:  Resource leaks  (RESOURCE_LEAK)
      >>>     Variable "auth_port" going out of scope leaks the storage it points to.
      607         return sasl_plugin;
      608     
      609         error:
      610             qd_log(cm->log_source, QD_LOG_ERROR, "Unable to create SASL plugin config: %s", qd_error_message());
      611             config_sasl_plugin_free(cm, sasl_plugin);
      612             return 0;

• • CID 277469:  Resource leaks  (RESOURCE_LEAK)
    /home/kgiusti/work/dispatch/qpid-dispatch/src/connection_manager.c: 607 in qd_dispatch_configure_sasl_plugin()

________________________________________________________________________________________________________

• • • CID 277469:  Resource leaks  (RESOURCE_LEAK)
      /home/kgiusti/work/dispatch/qpid-dispatch/src/connection_manager.c: 607 in qd_dispatch_configure_sasl_plugin()
      601         }
      602     
      603         sasl_plugin->sasl_init_hostname         = qd_entity_opt_string(entity, "realm", 0); CHECK();
      604         sasl_plugin->auth_ssl_profile           = qd_entity_opt_string(entity, "sslProfile", 0); CHECK();
      605     
      606         qd_log(cm->log_source, QD_LOG_INFO, "Created SASL plugin config with name %s", sasl_plugin->name);
      >>>     CID 277469:  Resource leaks  (RESOURCE_LEAK)
      >>>     Variable "auth_host" going out of scope leaks the storage it points to.
      607         return sasl_plugin;
      608     
      609         error:
      610             qd_log(cm->log_source, QD_LOG_ERROR, "Unable to create SASL plugin config: %s", qd_error_message());
      611             config_sasl_plugin_free(cm, sasl_plugin);
      612             return 0;