Uploaded image for project: 'Qpid Dispatch'
  1. Qpid Dispatch
  2. DISPATCH-915

connection rhost not calculated soon enough

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Not A Problem
    • 1.1.0
    • 1.1.0
    • Policy Engine
    • None
    • Fedora 25

    Description

      In DISPATCH-912 the rhost extraction was done earlier so that self tests would pass. The extraction needs to be done even earlier so that the policy engine properly accounts for connection life cycles. As-is there is most likely a memory leak. In 0.8.x connections are created and destroyed under the same name. In current master they are created with blank name and destroyed with a non-blank name.

      0.8.x
      =====
      2018-01-16 15:52:15.367634 -0500 POLICY (trace) ALLOW Connection '10.18.96.1:60660' based on global connection count. nConnections= 1 (/home/chug/git/qpid-dispatch/src/policy.c:197)
      2018-01-16 15:52:15.369923 -0500 POLICY (trace) ALLOW AMQP Open lookup_user: anonymous, rhost: 10.18.96.1, vhost: 10.3.116.250, connection: 10.18.96.1:60660. Usergroup: '$default' (/home/chug/git/qpid-dispatch/src/policy.c:356)
      2018-01-16 15:52:15.372801 -0500 POLICY (trace) ALLOW AMQP Begin Session. user: anonymous, rhost: 10.18.96.1, vhost: 10.3.116.250 (/home/chug/git/qpid-dispatch/src/policy.c:411)
      2018-01-16 15:52:15.374975 -0500 POLICY (trace) ALLOW AMQP Attach receiver link 'q1' for user 'anonymous', rhost '10.18.96.1', vhost '10.3.116.250' based on link source name (/home/chug/git/qpid-dispatch/src/policy.c:665)
      2018-01-16 15:52:15.378168 -0500 POLICY (trace) ALLOW AMQP Attach sender link 'q1' for user 'anonymous', rhost '10.18.96.1', vhost '10.3.116.250' based on link target name (/home/chug/git/qpid-dispatch/src/policy.c:603)
      2018-01-16 15:52:16.596565 -0500 POLICY (debug) Connection '10.18.96.1:60660' closed with resources n_sessions=0, n_senders=0, n_receivers=0. nConnections= 0. (/home/chug/git/qpid-dispatch/src/policy.c:244)
      
      master (3c403)
      ==============
      2018-01-16 15:47:28.992716 -0500 POLICY (trace) ALLOW Connection '' based on global connection count. nConnections= 1 (/home/chug/git/qpid-dispatch/src/policy.c:193)
      2018-01-16 15:47:29.20329 -0500 POLICY (trace) ALLOW AMQP Open lookup_user: anonymous, rhost: 10.18.96.1, vhost: 10.3.116.250, connection: 10.18.96.1:60622. Usergroup: '$default' (/home/chug/git/qpid-dispatch/src/policy.c:351)
      2018-01-16 15:47:29.35062 -0500 POLICY (trace) ALLOW AMQP Begin Session. user: anonymous, rhost: 10.18.96.1, vhost: 10.3.116.250 (/home/chug/git/qpid-dispatch/src/policy.c:406)
      2018-01-16 15:47:29.37329 -0500 POLICY (trace) ALLOW AMQP Attach receiver link 'q1' for user 'anonymous', rhost '10.18.96.1', vhost '10.3.116.250' based on link source name (/home/chug/git/qpid-dispatch/src/policy.c:659)
      2018-01-16 15:47:29.38853 -0500 POLICY (trace) ALLOW AMQP Attach sender link 'q1' for user 'anonymous', rhost '10.18.96.1', vhost '10.3.116.250' based on link target name (/home/chug/git/qpid-dispatch/src/policy.c:597)
      2018-01-16 15:47:30.20830 -0500 POLICY (debug) Connection '10.18.96.1:60622' closed with resources n_sessions=0, n_senders=0, n_receivers=0. nConnections= 0. (/home/chug/git/qpid-dispatch/src/policy.c:238)

      Attachments

        Activity

          People

            chug Charles E. Rolke
            chug Charles E. Rolke
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: