[DISPATCH-231] Router should not issue credit for unavailable targets

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.5
• Fix Version/s: 0.6.0
• Component/s: Router Node
• Assignee: Ted Ross
• Reporter: Ken Giusti
• Created: 03/Mar/16 15:22
• Updated: 20/Nov/17 18:39
• Resolved: 18/Mar/16 23:10

Description

When a client creates a sending link to a target, the router accepts the link on behalf of the target, and issues credit.

This happens even if the target is unknown (eg. no consumers exist).

In this case, the client will send a bunch of messages that simply stall or are released.

As an alternative, the router should only issue credit if the target is available.
Specifically:

1 - on attach, do not issue credit if the target is not available
2 - if the target goes away, stop issuing additional credit

#2 can result in in-flight messages being left in limbo. In this case, it is acceptable to drop those messages that have been sent pre-settled, and release those messages sent unsettled. Ideally, the router would hold on to these messages for a short time (TTL?) and re-send if the target becomes available in that time.

Issue Links

• is related to: DISPATCH-70 Configurable initial-credit and credit batching needed for incoming links