[DISPATCH-2285] Hide the API defined in address_lookup_utils.c by moving that file into router_core/modules/address_lookup_server directory

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.17.0
• Assignee: Unassigned
• Reporter: Jiri Daněk
• Created: 14/Nov/21 11:31
• Updated: 14/Nov/21 11:45

Description

Comment on https://github.com/apache/qpid-dispatch/pull/1211#discussion_r631820969

The address lookup stuff is only used by router-core module. It's not used by I/O threads, for example. This means that we should probably "hide" the API defined in address_lookup_utils.c by moving that file into router_core/modules/address_lookup_server directory.

Then I would move the address_lookup_server.h file out of the general include/qpid/dispatch directory and put it in src/router_core/ directory.

These changes would result in making the address lookup stuff private to the router_core module, which seems better to me since the address lookup functionality is only to be used by the router_core.

Issue Links

• Discovered while testing: DISPATCH-836 Source file organization suffers from include hell