[DISPATCH-2238] Avoid holding the core action lock when waking the core thread

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.17.0
• Fix Version/s: 1.18.0
• Component/s: Router Node
• Assignee: Ken Giusti
• Reporter: Ken Giusti
• Created: 24/Aug/21 00:55
• Updated: 19/Nov/21 21:43
• Resolved: 25/Aug/21 19:05

Description

Currently when an action is queued for the core to process, the queuing code calls pthread_cond_signal() while holding the associated mutex.  This can cause the core thread to be woken then immediately put sleep while taking the mutex.

 

It is legal to call pthread_cond_signal() without holding the lock. Doing this will avoid contention on the associated mutex.