[DISPATCH-2151] Race condition in libwebsocket logging handler in system_tests_http

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.17.0
• Labels: race-condition tsan
• Assignee: Unassigned
• Reporter: Jiri Daněk
• Created: 22/May/21 08:43
• Updated: 22/May/21 08:43

Description

https://github.com/apache/qpid-dispatch/pull/1231/checks?check_run_id=2640447633#step:25:2103

57: WARNING: ThreadSanitizer: data race (pid=3793)
57:   Read of size 8 at 0x7f89eeffcb10 by main thread (mutexes: write M13):
57:     #0 logger /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/http-libwebsockets.c:58 (libqpid-dispatch.so+0xf875e)
57:     #1 logger /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/http-libwebsockets.c:52 (libqpid-dispatch.so+0xf875e)
57:     #2 _lws_logv.part.0 <null> (libwebsockets.so.17+0x172fe)
57:     #3 qd_http_server_listen /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/http-libwebsockets.c:1002 (libqpid-dispatch.so+0xfac96)
57:     #4 qd_listener_listen_http /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1633 (libqpid-dispatch.so+0xf4125)
57:     #5 qd_listener_listen /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1646 (libqpid-dispatch.so+0xf4125)
57:     #6 qd_connection_manager_start /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/connection_manager.c:1010 (libqpid-dispatch.so+0x70179)
57:     #7 ffi_call_unix64 <null> (libffi.so.6+0x6c03)
57:     #8 main_process /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:97 (qdrouterd+0x40281c)
57:     #9 main /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x4024fc)
57: 
57:   Previous write of size 8 at 0x7f89eeffcb10 by thread T2:
57:     #0 log_init /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/http-libwebsockets.c:62 (libqpid-dispatch.so+0xf8353)
57:     #1 listener_start /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/http-libwebsockets.c:303 (libqpid-dispatch.so+0xf9d89)
57:     #2 http_thread_run /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/http-libwebsockets.c:916 (libqpid-dispatch.so+0xfa6fa)
57:     #3 _thread_init /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x95fa2)
57: 
57:   Location is global 'http_log' of size 8 at 0x7f89eeffcb10 (libqpid-dispatch.so+0x000000139b10)
57: 
57:   Mutex M13 (0x7b1000000300) created at:
57:     #0 pthread_mutex_init <null> (libtsan.so.0+0x49603)
57:     #1 sys_mutex /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:43 (libqpid-dispatch.so+0x95ffc)
57:     #2 qd_python_initialize /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/python_embedded.c:54 (libqpid-dispatch.so+0x9858c)
57:     #3 qd_dispatch /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:111 (libqpid-dispatch.so+0x763c5)
57:     #4 main_process /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:92 (qdrouterd+0x4027b9)
57:     #5 main /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x4024fc)
57: 
57:   Thread T2 (tid=3796, running) created by main thread at:
57:     #0 pthread_create <null> (libtsan.so.0+0x5bf45)
57:     #1 sys_thread /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x9643e)
57:     #2 qd_http_server_listen /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/http-libwebsockets.c:993 (libqpid-dispatch.so+0xfacbe)
57:     #3 qd_listener_listen_http /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1633 (libqpid-dispatch.so+0xf4125)
57:     #4 qd_listener_listen /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1646 (libqpid-dispatch.so+0xf4125)
57:     #5 qd_connection_manager_start /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/connection_manager.c:1010 (libqpid-dispatch.so+0x70179)
57:     #6 ffi_call_unix64 <null> (libffi.so.6+0x6c03)
57:     #7 main_process /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:97 (qdrouterd+0x40281c)
57:     #8 main /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x4024fc)
57: 
57: SUMMARY: ThreadSanitizer: data race /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/http-libwebsockets.c:58 in logger
57: ==================
57: ThreadSanitizer: reported 1 warnings