[DISPATCH-2140] race setting/reading qdr_connection_t context

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.16.0
• Fix Version/s: 1.20.0
• Component/s: Router Node
• Labels: race-condition tsan
• Assignee: Ken Giusti
• Reporter: Ken Giusti
• Created: 19/May/21 19:08
• Updated: 15/Mar/22 21:54

Description

69: test_008_put_10 (system_tests_http1_over_tcp.Http1OverTcpOneRouterTest) ... ok

69: WARNING: ThreadSanitizer: data race (pid=17014)
69: Read of size 8 at 0x7b5400089a10 by thread T1:
69: #0 qdr_connection_get_context /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:237 (libqpid-dispatch.so+0xa7587)
69: #1 qdr_tcp_activate /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:1573 (libqpid-dispatch.so+0x596f8)
69: #2 qdr_activate_connections_CT /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:89 (libqpid-dispatch.so+0xca7d4)
69: #3 router_core_thread /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:247 (libqpid-dispatch.so+0xca7d4)
69: #4 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16)
69: #5 <null> <null> (libtsan.so.0+0x2d1af)

69: Previous write of size 8 at 0x7b5400089a10 by thread T2:
69: #0 qdr_connection_set_context /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:162 (libqpid-dispatch.so+0xa72ea)
69: #1 handle_disconnected /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:499 (libqpid-dispatch.so+0x5d2a8)
69: #2 handle_connection_event /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:804 (libqpid-dispatch.so+0x5d2a8)
69: #3 handle_event_with_context /home/travis/build/apache/qpid-dispatch/src/server.c:802 (libqpid-dispatch.so+0xed109)
69: #4 do_handle_raw_connection_event /home/travis/build/apache/qpid-dispatch/src/server.c:808 (libqpid-dispatch.so+0xed109)
69: #5 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1089 (libqpid-dispatch.so+0xed109)
69: #6 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf0ad7)
69: #7 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16)
69: #8 <null> <null> (libtsan.so.0+0x2d1af)

69: Location is heap block of size 640 at 0x7b5400089800 allocated by thread T4:
69: #0 posix_memalign <null> (libtsan.so.0+0x3048d)
69: #1 qd_alloc /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396 (libqpid-dispatch.so+0x614c4)
69: #2 new_qdr_connection_t /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:44 (libqpid-dispatch.so+0xa6895)
69: #3 qdr_connection_opened /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:89 (libqpid-dispatch.so+0xa6ca6)
69: #4 qdr_tcp_connection_ingress_accept /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:701 (libqpid-dispatch.so+0x5cb8a)
69: #5 handle_connection_event /home/travis/build/apache/qpid-dispatch/src/adaptors/tcp_adaptor.c:759 (libqpid-dispatch.so+0x5cb8a)
69: #6 handle_event_with_context /home/travis/build/apache/qpid-dispatch/src/server.c:802 (libqpid-dispatch.so+0xed109)
69: #7 do_handle_raw_connection_event /home/travis/build/apache/qpid-dispatch/src/server.c:808 (libqpid-dispatch.so+0xed109)
69: #8 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1089 (libqpid-dispatch.so+0xed109)
69: #9 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf0ad7)
69: #10 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16)
69: #11 <null> <null> (libtsan.so.0+0x2d1af)

69: Thread T1 (tid=17016, running) created by main thread at:
69: #0 pthread_create <null> (libtsan.so.0+0x5ea99)
69: #1 sys_thread /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x974d2)
69: #2 qdr_core /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:124 (libqpid-dispatch.so+0xc4bee)
69: #3 qd_router_setup_late /home/travis/build/apache/qpid-dispatch/src/router_node.c:2123 (libqpid-dispatch.so+0xe865c)
69: #4 <null> <null> (libffi.so.7+0x6ff4)
69: #5 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:97 (qdrouterd+0x2bb2)
69: #6 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882)

69: Thread T2 (tid=17017, running) created by main thread at:
69: #0 pthread_create <null> (libtsan.so.0+0x5ea99)
69: #1 sys_thread /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x974d2)
69: #2 qd_server_run /home/travis/build/apache/qpid-dispatch/src/server.c:1499 (libqpid-dispatch.so+0xf0cca)
69: #3 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:115 (qdrouterd+0x2c27)
69: #4 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882)

69: Thread T4 (tid=17019, running) created by main thread at:
69: #0 pthread_create <null> (libtsan.so.0+0x5ea99)
69: #1 sys_thread /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x974d2)
69: #2 qd_server_run /home/travis/build/apache/qpid-dispatch/src/server.c:1499 (libqpid-dispatch.so+0xf0cca)
69: #3 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:115 (qdrouterd+0x2c27)
69: #4 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882)

69: SUMMARY: ThreadSanitizer: data race /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:237 in qdr_connection_get_context