[DISPATCH-2093] [tcp] TCP deliveries are counted as modified

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 1.15.0, 1.16.0
• Component/s: Protocol Adaptors
• Assignee: Ken Giusti
• Reporter: Ken Giusti
• Created: 30/Apr/21 14:13
• Updated: 17/Mar/22 12:31
• Resolved: 17/Mar/22 00:33

Description

TCP deliveries that pass over inter router links are being counted as 'modified' once the TCP connections complete.   Since the inter router links survive much longer than the TCP links, the "modified" counters are visible long after TCP i done.

 

Proposed fix:

Add to void handle_disconnected(qdr_tcp_connection_t* conn):

qd_log(tcp_adaptor->log_source, QD_LOG_DEBUG, "[C%"PRIu64"][L%"PRIu64"] handle_disconnected - close outstream", conn->conn_id, conn->outgoing_id);

+ qdr_delivery_remote_state_updated(tcp_adaptor->core,
+                                   conn->outstream,
+                                   PN_ACCEPTED,
+                                   true, // settled,
+                                   0, // delivery state
+                                   false);

qdr_delivery_decref(tcp_adaptor->core, conn->outstream, "tcp-adaptor.handle_disconnected - outstream");