[DISPATCH-2061] TSan race from system_tests_topology in qd_entity_refresh_connector

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.16.0
• Assignee: Unassigned
• Reporter: Jiri Daněk
• Created: 20/Apr/21 16:18
• Updated: 20/Apr/21 16:34
• Resolved: 20/Apr/21 16:34

Description

https://travis-ci.com/github/apache/qpid-dispatch/jobs/499822681#L5948

45: ======================================================================
45: ERROR: tearDownClass (system_tests_topology.RouterFluxTest)
45: ----------------------------------------------------------------------
45: Traceback (most recent call last):
45:   File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py", line 865, in tearDownClass
45:     cls.tester.teardown()
45:   File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py", line 808, in teardown
45:     raise RuntimeError("Errors during teardown: \n\n%s" % "\n\n".join([str(e) for e in errors]))
45: RuntimeError: Errors during teardown: 
45: 
45: Process 15411 error: exit code 66, expected 0
45: qdrouterd -c INT.A.conf -I /home/travis/build/apache/qpid-dispatch/python
45: /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_topology/RouterFluxTest/test_01_reboot_INT_A/INT.A-4.cmd
45: >>>>
45: ==================
45: WARNING: ThreadSanitizer: data race (pid=15411)
45:   Read of size 8 at 0x7b4400000a00 by thread T3 (mutexes: write M5, write M245, write M0):
45:     #0 strlen <null> (libtsan.so.0+0x32abf)
45:     #1 PyUnicode_FromString <null> (libpython3.8.so.1.0+0x22f9dc)
45:     #2 qd_entity_refresh_connector /home/travis/build/apache/qpid-dispatch/src/connection_manager.c:869 (libqpid-dispatch.so+0x70ec6)
45:     #3 <null> <null> (libffi.so.7+0x6ff4)
45:     #4 qdr_forward_on_message /home/travis/build/apache/qpid-dispatch/src/router_core/forwarder.c:338 (libqpid-dispatch.so+0xba41f)
45:     #5 qdr_general_handler /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:926 (libqpid-dispatch.so+0xc3089)
45:     #6 qd_timer_visit /home/travis/build/apache/qpid-dispatch/src/timer.c:205 (libqpid-dispatch.so+0xf0e77)
45:     #7 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1006 (libqpid-dispatch.so+0xeb86e)
45:     #8 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1120 (libqpid-dispatch.so+0xed707)
45:     #9 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x95f26)
45:     #10 <null> <null> (libtsan.so.0+0x2d1af)
45: 
45:   Previous write of size 8 at 0x7b4400000a00 by thread T2:
45:     #0 strcpy <null> (libtsan.so.0+0x45931)
45:     #1 strcpy /usr/include/x86_64-linux-gnu/bits/string_fortified.h:90 (libqpid-dispatch.so+0xe5e96)
45:     #2 AMQP_opened_handler /home/travis/build/apache/qpid-dispatch/src/router_node.c:1388 (libqpid-dispatch.so+0xe5e96)
45:     #3 AMQP_outbound_opened_handler /home/travis/build/apache/qpid-dispatch/src/router_node.c:1549 (libqpid-dispatch.so+0xe6be7)
45:     #4 notify_opened /home/travis/build/apache/qpid-dispatch/src/container.c:277 (libqpid-dispatch.so+0x729d3)
45:     #5 policy_notify_opened /home/travis/build/apache/qpid-dispatch/src/container.c:288 (libqpid-dispatch.so+0x729d3)
45:     #6 qd_policy_amqp_open_connector /home/travis/build/apache/qpid-dispatch/src/policy.c:1373 (libqpid-dispatch.so+0x91a5e)
45:     #7 qd_container_handle_event /home/travis/build/apache/qpid-dispatch/src/container.c:515 (libqpid-dispatch.so+0x754fc)
45:     #8 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1095 (libqpid-dispatch.so+0xeb7a1)
45:     #9 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1120 (libqpid-dispatch.so+0xed68c)
45:     #10 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x95f26)
45:     #11 <null> <null> (libtsan.so.0+0x2d1af)
45: 
45:   Location is heap block of size 300 at 0x7b4400000a00 allocated by main thread:
45:     #0 malloc <null> (libtsan.so.0+0x30343)
45:     #1 qd_server_connector /home/travis/build/apache/qpid-dispatch/src/server.c:1658 (libqpid-dispatch.so+0xef727)
45:     #2 qd_dispatch_configure_connector /home/travis/build/apache/qpid-dispatch/src/connection_manager.c:879 (libqpid-dispatch.so+0x70f21)
45:     #3 <null> <null> (libffi.so.7+0x6ff4)
45:     #4 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:97 (qdrouterd+0x2bb2)
45:     #5 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882)
45: 
45:   Mutex M5 (0x7b1000000300) created at:
45:     #0 pthread_mutex_init <null> (libtsan.so.0+0x4a636)
45:     #1 sys_mutex /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:43 (libqpid-dispatch.so+0x95f8f)
45:     #2 qd_python_initialize /home/travis/build/apache/qpid-dispatch/src/python_embedded.c:54 (libqpid-dispatch.so+0x988e7)
45:     #3 qd_dispatch /home/travis/build/apache/qpid-dispatch/src/dispatch.c:111 (libqpid-dispatch.so+0x77359)
45:     #4 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:92 (qdrouterd+0x2b39)
45:     #5 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882)
45: 
45:   Mutex M245 (0x7b1000002c40) created at:
45:     #0 pthread_mutex_init <null> (libtsan.so.0+0x4a636)
45:     #1 sys_mutex /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:43 (libqpid-dispatch.so+0x95f8f)
45:     #2 qd_router /home/travis/build/apache/qpid-dispatch/src/router_node.c:1631 (libqpid-dispatch.so+0xe6dda)
45:     #3 qd_dispatch_prepare /home/travis/build/apache/qpid-dispatch/src/dispatch.c:335 (libqpid-dispatch.so+0x76f63)
45:     #4 <null> <null> (libffi.so.7+0x6ff4)
45:     #5 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:97 (qdrouterd+0x2bb2)
45:     #6 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882)
45: 
45:   Mutex M0 (0x7b1000000200) created at:
45:     #0 pthread_mutex_init <null> (libtsan.so.0+0x4a636)
45:     #1 sys_mutex /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:43 (libqpid-dispatch.so+0x95f8f)
45:     #2 qd_entity_cache_initialize /home/travis/build/apache/qpid-dispatch/src/entity_cache.c:55 (libqpid-dispatch.so+0x786da)
45:     #3 qd_dispatch /home/travis/build/apache/qpid-dispatch/src/dispatch.c:88 (libqpid-dispatch.so+0x7720e)
45:     #4 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:92 (qdrouterd+0x2b39)
45:     #5 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882)
45: 
45:   Thread T3 (tid=15415, running) created by main thread at:
45:     #0 pthread_create <null> (libtsan.so.0+0x5ea99)
45:     #1 sys_thread /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x964e2)
45:     #2 qd_server_run /home/travis/build/apache/qpid-dispatch/src/server.c:1485 (libqpid-dispatch.so+0xee17a)
45:     #3 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:115 (qdrouterd+0x2c27)
45:     #4 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882)
45: 
45:   Thread T2 (tid=15414, running) created by main thread at:
45:     #0 pthread_create <null> (libtsan.so.0+0x5ea99)
45:     #1 sys_thread /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x964e2)
45:     #2 qd_server_run /home/travis/build/apache/qpid-dispatch/src/server.c:1485 (libqpid-dispatch.so+0xee17a)
45:     #3 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:115 (qdrouterd+0x2c27)
45:     #4 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882)
45: 
45: SUMMARY: ThreadSanitizer: data race (/lib/x86_64-linux-gnu/libtsan.so.0+0x32abf) in __interceptor_strlen
45: ==================
45: ThreadSanitizer: reported 1 warnings
45: <<<<
45: 
45: ----------------------------------------------------------------------
45: Ran 3 tests in 41.372s
45: 
45: FAILED (errors=1)
45/74 Test #45: system_tests_topology .............................***Failed   41.49 sec

Issue Links

• duplicates: DISPATCH-1917 Thread race accessing connector->conn_msg buffer (TSAN)