[DISPATCH-2037] [http2] Thread race accessing qdr_http2_connection_t pings in system_tests_http2

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.16.0
• Fix Version/s: 1.17.0
• Labels: race-condition tsan
• Assignee: Ganesh Murthy
• Reporter: Jiri Daněk
• Created: 06/Apr/21 06:51
• Updated: 23/Aug/21 15:02
• Resolved: 23/Jul/21 21:00

Description

https://travis-ci.com/github/apache/qpid-dispatch/jobs/496286761#L6889

68: WARNING: ThreadSanitizer: data race (pid=16868)
68:   Read of size 8 at 0x7b4800005fb0 by thread T4:
68:     #0 egress_conn_ping_sender /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2228 (libqpid-dispatch.so+0xf3c6d)
68:     #1 egress_conn_ping_sender /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2206 (libqpid-dispatch.so+0xf3c6d)
68:     #2 qd_timer_visit /home/travis/build/apache/qpid-dispatch/src/timer.c:205 (libqpid-dispatch.so+0xefbd7)
68:     #3 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1008 (libqpid-dispatch.so+0xea5de)
68:     #4 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1122 (libqpid-dispatch.so+0xec477)
68:     #5 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:174 (libqpid-dispatch.so+0x94e86)
68:     #6 <null> <null> (libtsan.so.0+0x2d1af)
68: 
68:   Previous write of size 8 at 0x7b4800005fb0 by thread T3:
68:     #0 handle_connection_event /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2447 (libqpid-dispatch.so+0xfe9fd)
68:     #1 handle_event_with_context /home/travis/build/apache/qpid-dispatch/src/server.c:804 (libqpid-dispatch.so+0xea569)
68:     #2 do_handle_raw_connection_event /home/travis/build/apache/qpid-dispatch/src/server.c:810 (libqpid-dispatch.so+0xea569)
68:     #3 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1090 (libqpid-dispatch.so+0xea569)
68:     #4 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1122 (libqpid-dispatch.so+0xec477)
68:     #5 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:174 (libqpid-dispatch.so+0x94e86)
68:     #6 <null> <null> (libtsan.so.0+0x2d1af)
68: 
68:   Location is heap block of size 384 at 0x7b4800005e80 allocated by main thread:
68:     #0 posix_memalign <null> (libtsan.so.0+0x3048d)
68:     #1 qd_alloc /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:395 (libqpid-dispatch.so+0x5f5d4)
68:     #2 new_qdr_http2_connection_t /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:52 (libqpid-dispatch.so+0xf66c5)
68:     #3 qdr_http_connection_egress /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2312 (libqpid-dispatch.so+0xfece5)
68:     #4 qd_http2_configure_connector /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2584 (libqpid-dispatch.so+0xffdfc)
68:     #5 qd_dispatch_configure_http_connector /home/travis/build/apache/qpid-dispatch/src/adaptors/http_common.c:172 (libqpid-dispatch.so+0x3eebd)
68:     #6 <null> <null> (libffi.so.7+0x6ff4)
68:     #7 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:97 (qdrouterd+0x2bb2)
68:     #8 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882)
68: 
68:   Thread T4 (tid=16873, running) created by main thread at:
68:     #0 pthread_create <null> (libtsan.so.0+0x5ea99)
68:     #1 sys_thread /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:183 (libqpid-dispatch.so+0x95442)
68:     #2 qd_server_run /home/travis/build/apache/qpid-dispatch/src/server.c:1485 (libqpid-dispatch.so+0xeceda)
68:     #3 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:115 (qdrouterd+0x2c27)
68:     #4 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882)
68: 
68:   Thread T3 (tid=16872, running) created by main thread at:
68:     #0 pthread_create <null> (libtsan.so.0+0x5ea99)
68:     #1 sys_thread /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:183 (libqpid-dispatch.so+0x95442)
68:     #2 qd_server_run /home/travis/build/apache/qpid-dispatch/src/server.c:1485 (libqpid-dispatch.so+0xeceda)
68:     #3 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:115 (qdrouterd+0x2c27)
68:     #4 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882)
68: 
68: SUMMARY: ThreadSanitizer: data race /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2228 in egress_conn_ping_sender
68: ==================
68: ThreadSanitizer: reported 1 warnings