[DISPATCH-1854] Delivery id numbers could be added for better log message comprehension

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.14.0
• Fix Version/s: 1.15.0
• Component/s: Protocol Adaptors, Router Node, Routing Engine
• Assignee: Charles E. Rolke
• Reporter: Charles E. Rolke
• Created: 23/Nov/20 17:20
• Updated: 11/Feb/21 17:54
• Resolved: 05/Jan/21 17:01

Description

Deliveries could use id numbers similar to qd_server_t.next_connection_id numbers.

Then the delivery id numbers could be used in places where the qd_delivery_t object addresses are printed in logs. This would eliminate the ambiguity with the object addresses that get reused.

The effort to scavenge the extra info for logs could be wrapped in qd_log_enabled conditionals so that the work is done only when the log is to be printed.

Where possible log lines with delivery info could be prefixed with connection, link, and delivery id numbers like [C12][L34][D105]

Delivery ids could be added to transfer and settlement log lines.

Issue Links

• blocks: DISPATCH-1906 Coverity error relating to adding delivery id in trace logs