[DISPATCH-1765] use connection-capabilities for streaming-links support detection

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.13.0
• Fix Version/s: 1.14.0
• Assignee: Ken Giusti
• Reporter: Ken Giusti
• Created: 27/Aug/20 15:29
• Updated: 14/Sep/20 21:33
• Resolved: 01/Sep/20 15:10

Description

Change to using connection-capabilities for advertisement and detection of the streaming-links support added in DISPATCH-1545.

Note that this change means the feature will not activate between a 1.14.0+ router and earlier 1.13.0 routers as the former did not advertise the capability. Few should encounter this given 1.14.0 follows soon behind 1.13.0 and essentially replaces it.

 

= Original Description =

The version string advertised by the router in the Open performative may be parsed incorrectly if a non-semantic format is used (e.g. a git commit sha).

Currently the router uses the router version of its peer in order to determine if the peer supports certain features like streaming links.

Two changes proposed to solve this:

1) do not attempt to parse the version string arriving in the Open performative.  Treat it as opaque ascii data.

2) Add router-defined capabilities and advertise them in the offered-capabilities field of the Open performative.

 

Issue Links

• fixes: DISPATCH-1545 Streaming deliveries can be delayed by head-of-line blocking on inter-router links