[DISPATCH-1631] system_tests_bad_configuration fails if the router is not already installed

• Type: Test
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.12.0
• Fix Version/s: 1.13.0
• Component/s: Tests
• Assignee: Charles E. Rolke
• Reporter: Robbie Gemmell
• Created: 28/Apr/20 09:36
• Updated: 18/Aug/20 01:01
• Resolved: 29/Apr/20 20:05

Description

test_verify_reject_id_with_ctrl_char and test_verify_reject_id_with_whitespace from system_tests_bad_configuration fail unless the router is already installed, which is annoying given it is typical to test before installing.

If the tests do need an install for some reason they could perhaps verify one exists which works with good config, rather than fail because one doesnt exist.

I have noted similar issues with tests in the past, which seems to point to a change needed in the CI to actually catch such things as they happen.

 Start 51: system_tests_bad_configuration

51: Test command: /usr/bin/python "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/tests/run.py" "-m" "unittest" "-v" "system_tests_bad_configuration"
51: Test timeout computed to be: 600
51: test_qdmanage_query (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
51: test_unresolvable_host_caught (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
51: 
51: Router QDR.A debug dump file:
51: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1
51: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1
51: test_verify_reject_id_with_ctrl_char (system_tests_bad_configuration.RouterTestIdFailCtrlChar) ... FAIL
51: test_verify_reject_id_with_whitespace (system_tests_bad_configuration.RouterTestIdFailWhiteSpace) ... FAIL
51: 
51: ======================================================================
51: FAIL: test_verify_reject_id_with_ctrl_char (system_tests_bad_configuration.RouterTestIdFailCtrlChar)
51: ----------------------------------------------------------------------
51: Traceback (most recent call last):
51: File "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py", line 203, in test_verify_reject_id_with_ctrl_char
51: assert False, "AttributeError not in process output"
51: AssertionError: AttributeError not in process output
51: 
51: ======================================================================
51: FAIL: test_verify_reject_id_with_whitespace (system_tests_bad_configuration.RouterTestIdFailWhiteSpace)
51: ----------------------------------------------------------------------
51: Traceback (most recent call last):
51: File "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py", line 243, in test_verify_reject_id_with_whitespace
51: assert False, "AttributeError not in process output"
51: AssertionError: AttributeError not in process output
51: 
51: ----------------------------------------------------------------------
51: Ran 4 tests in 1.293s
51: 
51: FAILED (failures=2)
51: output: 2020-04-28 09:57:22.734890 +0100 ERROR (error) Cannot find Python library path '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python': Unknown error 2
51: qdrouterd: Cannot find Python library path '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python': Unknown error 2
51: 
51: output: 2020-04-28 09:57:22.838318 +0100 ERROR (error) Cannot find Python library path '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python': Unknown error 2
51: qdrouterd: Cannot find Python library path '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python': Unknown error 2
51: 
1/1 Test #51: system_tests_bad_configuration ...***Failed 1.35 sec