[DISPATCH-1630] Coverity issues on master branch

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.0
• Fix Version/s: 1.12.0
• Component/s: Container
• Assignee: Ganesh Murthy
• Reporter: Ganesh Murthy
• Created: 27/Apr/20 13:36
• Updated: 30/Apr/20 21:44
• Resolved: 27/Apr/20 18:23

Description

New defect(s) Reported-by: Coverity Scan

Showing 1 of 1 defect(s)





** CID 355485:  Null pointer dereferences  (FORWARD_NULL)





________________________________________________________________________________________________________

*** CID 355485:  Null pointer dereferences  (FORWARD_NULL)

/home/gmurthy/opensource/qpid-dispatch/src/http-libwebsockets.c: 181 in handle_events()

175     static int handle_events(connection_t* c) {

176         if (!c->qd_conn) {

177             return unexpected_close(c->wsi, "not-established");

178         }

179         pn_event_t *e;

180         while ((e = pn_connection_driver_next_event(&c->driver))) {

>>>     CID 355485:  Null pointer dereferences  (FORWARD_NULL)

>>>     Passing null pointer "c->qd_conn" to "qd_connection_handle", which dereferences it.

181             if (!qd_connection_handle(c->qd_conn, e)) {

182                 c->qd_conn = 0;  // connection closed

183             }

184         }

185         if (pn_connection_driver_write_buffer(&c->driver).size) {

186             lws_callback_on_writable(c->wsi);