Uploaded image for project: 'Qpid Dispatch'
  1. Qpid Dispatch
  2. DISPATCH-1403

Consolidate chained qd_buffer_t field handling code

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.8.0, 1.9.0
    • Fix Version/s: Backlog
    • Component/s: Router Node
    • Labels:

      Description

      There are many places in the router's C codebase where we need to work with data spanning a chained qd_buffer_t list. In particular the low level operations such as:

      • advance N bytes
      • compare N bytes
      • copy N bytes
        are common throughout the code.

      Here are examples from the iterator.c library:
      copy bytes
      advance cursor
      compare

      Similar logic is implemented in message.c and parse.c.

      We should de-duplicate this code by providing a common implementation as part of the buffer handling code.

        Attachments

          Activity

            People

            • Assignee:
              kgiusti Ken Giusti
              Reporter:
              kgiusti Ken Giusti
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: