[DISPATCH-1368] Link (address) priority is ignored by the second hop router

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.8.0, 1.9.0
• Component/s: Router Node
• Assignee: Michael Goulish
• Reporter: Ken Giusti
• Created: 14/Jun/19 15:16
• Updated: 18/Sep/19 12:29

Description

Address-based priority is only enforced on the egress of the first hop router.

In a 3 router linear network:

Sender --> Router A --> Router B --> Router C --> Receiver

Message delivery is properly sent via the inter-router links between Router A and Router B.

However, those messages are all forwarded on the default priority (4) between router B and C.

[C --> Receiver is fine - priority doesn't apply to egress endpoint links]

The expectation is that the message priority is honored across all inter-router links.

Reproducer

Build the router, then run the priority test (ctest -VV -R priority).

Then grep for "DELIVERIES" in the log files:

 grep "DELIVERIES" tests/system_test.dir/system_tests_priority/CongestionTests/setUpClass/*.log
tests/system_test.dir/system_tests_priority/CongestionTests/setUpClass/A.log:2019-06-14 11:10:00.324389 -0400 ROUTER (error) DELIVERIES PER PRIORITY: 9=20 8=0 7=28 6=0 5=0 4(default)=21 3=0 2=12 1=0 0=343 (/home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:188)
tests/system_test.dir/system_tests_priority/CongestionTests/setUpClass/B.log:2019-06-14 11:10:00.302570 -0400 ROUTER (error) DELIVERIES PER PRIORITY: 9=0 8=0 7=0 6=0 5=0 4(default)=172 3=0 2=0 1=0 0=286 (/home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:188)
...

Notice the counts on A (tx to B) - these are correct.

On B all msgs are sent priority 4 (default) to C - this is wrong.

 

 

 

 

Issue Links

• depends upon: PROTON-335 Need a means of specifying and reading link properties