[DISPATCH-1222] coverity static analysis reports several issues

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.1
• Fix Version/s: 1.5.0
• Component/s: Router Node
• Assignee: Ken Giusti
• Reporter: Ken Giusti
• Created: 13/Dec/18 19:23
• Updated: 14/Jan/19 21:28
• Resolved: 18/Dec/18 20:47

Description

Analysis summary report:
------------------------
Files analyzed : 93
Total LoC input to cov-analyze : 70993
Functions analyzed : 1597
Paths analyzed : 244441
Time taken by analysis : 00:00:36
Defect occurrences found : 157 Total
4 ATOMICITY
1 CONSTANT_EXPRESSION_RESULT
4 DC.WEAK_CRYPTO
2 DEADCODE
8 FORWARD_NULL
5 MISSING_LOCK
1 NEGATIVE_RETURNS
1 OVERLAPPING_COPY
16 PRINTF_ARGS
110 RESOURCE_LEAK
1 STRING_NULL
1 UNUSED_VALUE
3 USE_AFTER_FREE