Commons Discovery
  1. Commons Discovery
  2. DISCOVERY-16

The setLog() methods are not thread-safe and should be deprecated

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.5
    • Labels:
      None

      Description

      The static setLog() methods set a private static log instance.

      This may not be thread-safe, and even if the log instance is thread-safe, the updated value may not be seen by other threads.

      Therefore these methods should be deprecated.

        Activity

        Hide
        Simone Tripodi added a comment -

        included in discovery-0.5 release

        Show
        Simone Tripodi added a comment - included in discovery-0.5 release
        Hide
        Simone Tripodi added a comment -

        fixed on r1089311, thanks for reporting!

        Show
        Simone Tripodi added a comment - fixed on r1089311, thanks for reporting!
        Hide
        Simone Tripodi added a comment -

        +1 for the deprecation, I'll take care ASAP, thanks for reviewing!

        Show
        Simone Tripodi added a comment - +1 for the deprecation, I'll take care ASAP, thanks for reviewing!

          People

          • Assignee:
            Simone Tripodi
            Reporter:
            Sebb
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development