Directory Studio
  1. Directory Studio
  2. DIRSTUDIO-625

Add Connection Context in the LDAP Browser Window

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.2
    • Fix Version/s: 1.5.3
    • Component/s: studio-ldapbrowser
    • Labels:
      None
    • Environment:
      Windows 32

      Description

      When we navigate between multiple connections, we have to keep the connection window opened to see in which we currently are in the LDAP Browser window. It would be easier if the connection name appeared in the title window of the LDAP Browser or in the root node

      1. DIRSTUDIO-625.png
        80 kB
        Stefan Seelmann

        Activity

        Hide
        Stefan Seelmann added a comment -

        When the Plugins are installed within Eclipse the title bar actually shows connection context information in the window title, it is updated whenever another entry is opened. The following format is used:
        Perspective - Entry DN - Connection Name - Eclipse

        However in the RCP application we only have the static title "Apache Directory Studio".

        I figures out that in Eclipse the WorkbenchWindowsAdvisor implementation sets up some listeners that updates the title, see http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchWindowAdvisor.java?view=markup

        So I tried to adapt this class to our ApplicationWorkbenchWindowAdvisor, see the result in the attached image.

        Any thoughts before I commit the change?
        Is the order of the information (Perspective Name - Entry DN - Connection Name - Product Name) ok? At least it is the same order than in Eclipse.
        On Windows and Linux that should be ok. But how does it look like on MacOS (I think there is no window title)?

        Show
        Stefan Seelmann added a comment - When the Plugins are installed within Eclipse the title bar actually shows connection context information in the window title, it is updated whenever another entry is opened. The following format is used: Perspective - Entry DN - Connection Name - Eclipse However in the RCP application we only have the static title "Apache Directory Studio". I figures out that in Eclipse the WorkbenchWindowsAdvisor implementation sets up some listeners that updates the title, see http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchWindowAdvisor.java?view=markup So I tried to adapt this class to our ApplicationWorkbenchWindowAdvisor, see the result in the attached image. Any thoughts before I commit the change? Is the order of the information (Perspective Name - Entry DN - Connection Name - Product Name) ok? At least it is the same order than in Eclipse. On Windows and Linux that should be ok. But how does it look like on MacOS (I think there is no window title)?
        Hide
        Pierre-Arnaud Marcelot added a comment -

        Hi Stefan,

        This looks really great...

        It'll look the same on Mac OS X, there's also a window title.

        Show
        Pierre-Arnaud Marcelot added a comment - Hi Stefan, This looks really great... It'll look the same on Mac OS X, there's also a window title.
        Hide
        Jean-Marc added a comment -

        Hi Stefan,

        In our side, we would only add the connection name on the title bar. Info on the title bar should be kept concise and easy to read, in my opinion.

        Now, I understand that this is kind of an eclipse standard? Having the information displayed in the title bar - even with current DN - is better than not having it at all so I consider it an acceptable solution.

        Thank you.

        Show
        Jean-Marc added a comment - Hi Stefan, In our side, we would only add the connection name on the title bar. Info on the title bar should be kept concise and easy to read, in my opinion. Now, I understand that this is kind of an eclipse standard? Having the information displayed in the title bar - even with current DN - is better than not having it at all so I consider it an acceptable solution. Thank you.
        Show
        Stefan Seelmann added a comment - Fixed in trunk: http://svn.apache.org/viewcvs?view=rev&rev=920697 http://svn.apache.org/viewvc?rev=926769&view=rev
        Hide
        Pierre-Arnaud Marcelot added a comment -

        Version 1.5.3 has been release.
        Let's close this issue.

        Show
        Pierre-Arnaud Marcelot added a comment - Version 1.5.3 has been release. Let's close this issue.

          People

          • Assignee:
            Stefan Seelmann
            Reporter:
            Jean-Marc
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development