Directory Studio
  1. Directory Studio
  2. DIRSTUDIO-272

Use the rat maven plugin with the -Prelease profile option to generate releases

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: None
    • Labels:
      None
    1. rat.patch
      0.9 kB
      Felix Knecht

      Activity

      Hide
      Felix Knecht added a comment -

      It looks like the rat plugin is already defined in the directory/project/pom.xml - you can 'cd studio/trunk' and run 'mvn rat:check', it's working.
      But we can add rat report to the automatically generated reports by add followingpatch to the directory/project/trunk/pom.xml:

      $Index: pom.xml
      ===================================================================
      — pom.xml (revision 688981)
      +++ pom.xml (working copy)
      @@ -511,6 +511,10 @@
      </reportSet>
      </reportSets>
      </plugin>
      + <plugin>
      + <groupId>org.codehaus.mojo</groupId>
      + <artifactId>rat-maven-plugin</artifactId>
      + </plugin>
      </plugins>
      </reporting>

      If ever IMO the rat:check should be added to the directory/project/trunk/pom.xml release-profile to be used all over the place for directory subprojects

      WDOT?

      Show
      Felix Knecht added a comment - It looks like the rat plugin is already defined in the directory/project/pom.xml - you can 'cd studio/trunk' and run 'mvn rat:check', it's working. But we can add rat report to the automatically generated reports by add followingpatch to the directory/project/trunk/pom.xml: $Index: pom.xml =================================================================== — pom.xml (revision 688981) +++ pom.xml (working copy) @@ -511,6 +511,10 @@ </reportSet> </reportSets> </plugin> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>rat-maven-plugin</artifactId> + </plugin> </plugins> </reporting> If ever IMO the rat:check should be added to the directory/project/trunk/pom.xml release-profile to be used all over the place for directory subprojects WDOT?
      Hide
      Pierre-Arnaud Marcelot added a comment -

      I think it's a good idea!

      +1

      Show
      Pierre-Arnaud Marcelot added a comment - I think it's a good idea! +1
      Hide
      Felix Knecht added a comment -

      Hehe which one :-D

      The first, the second or both?

      Show
      Felix Knecht added a comment - Hehe which one :-D The first, the second or both?
      Hide
      Felix Knecht added a comment -

      Patch to enable rat project reports and rat check for release profile

      Show
      Felix Knecht added a comment - Patch to enable rat project reports and rat check for release profile
      Hide
      Felix Knecht added a comment -

      @PMC / Alex
      I think it's up to you to decide wether to apply the patch or not because of the huge amount of reported missing headers by rat:check for the projects. I can be a 'blocker' for releases in the near future.

      Show
      Felix Knecht added a comment - @PMC / Alex I think it's up to you to decide wether to apply the patch or not because of the huge amount of reported missing headers by rat:check for the projects. I can be a 'blocker' for releases in the near future.
      Hide
      Pierre-Arnaud Marcelot added a comment -

      I was thinking both.

      But, is this going to forbid us to release a version?

      Show
      Pierre-Arnaud Marcelot added a comment - I was thinking both. But, is this going to forbid us to release a version?
      Hide
      Felix Knecht added a comment -

      Add rat:check on TLP for report generation and -Prelease

      Show
      Felix Knecht added a comment - Add rat:check on TLP for report generation and -Prelease

        People

        • Assignee:
          Pierre-Arnaud Marcelot
          Reporter:
          Alex Karasulu
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development