Uploaded image for project: 'Directory Studio'
  1. Directory Studio
  2. DIRSTUDIO-1038

Dispose the various org.eclipse.swt.graphics.* objects we use

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 2.0.0-M8 (2.0.0.v20130628)
        • Fix Version/s: 2.0.0-M9 (2.0.0.v20150606-M9)
        • Component/s: None
        • Labels:
          None

          Description

          We usually forget to release the org.eclipse.swt.graphics.* classes instances. This might be a problem in some cases.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            elecharny Emmanuel Lecharny added a comment -

            More specifically, the resources that has to be disposed are :

            • org.eclipse.swt.graphics.Image
            • org.eclipse.swt.graphics.Color
            • org.eclipse.swt.graphics.Font
            • org.eclipse.swt.graphics.GC
            Show
            elecharny Emmanuel Lecharny added a comment - More specifically, the resources that has to be disposed are : org.eclipse.swt.graphics.Image org.eclipse.swt.graphics.Color org.eclipse.swt.graphics.Font org.eclipse.swt.graphics.GC
            Hide
            Permalink
            elecharny Emmanuel Lecharny added a comment - - edited

            All the GC instances are correctly disposed (I change the code so that even if we get an exception, the element is still disposed).

            Show
            elecharny Emmanuel Lecharny added a comment - - edited All the GC instances are correctly disposed (I change the code so that even if we get an exception, the element is still disposed).
            Hide
            Permalink
            elecharny Emmanuel Lecharny added a comment -

            For the other elements, we should most certainly use the ColorRegistry, FontRegistry and ImageRegistry which will hold and dispose the elements.

            Show
            elecharny Emmanuel Lecharny added a comment - For the other elements, we should most certainly use the ColorRegistry , FontRegistry and ImageRegistry which will hold and dispose the elements.
            Hide
            Permalink
            elecharny Emmanuel Lecharny added a comment -

            The Font are now get from the default FontRegistry, we don't have to dispose them anymore.

            Show
            elecharny Emmanuel Lecharny added a comment - The Font are now get from the default FontRegistry , we don't have to dispose them anymore.
            Hide
            Permalink
            elecharny Emmanuel Lecharny added a comment -

            The Image instances are all correctly disposed.

            Show
            elecharny Emmanuel Lecharny added a comment - The Image instances are all correctly disposed.
            Hide
            Permalink
            elecharny Emmanuel Lecharny added a comment -

            The Color are now all disposed.

            Show
            elecharny Emmanuel Lecharny added a comment - The Color are now all disposed.
            Hide
            Permalink
            elecharny Emmanuel Lecharny added a comment -

            We now dispose all the swt elements we use.

            Show
            elecharny Emmanuel Lecharny added a comment - We now dispose all the swt elements we use.

              People

              • Assignee:
                Unassigned
                Reporter:
                elecharny Emmanuel Lecharny
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development