Directory Studio
  1. Directory Studio
  2. DIRSTUDIO-100

Interface IRootDSE does not sufficiently define return values of methods

    Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0
    • Component/s: None
    • Labels:
      None

      Description

      I think the interface org.apache.directory.ldapstudio.browser.core.model.IRootDSE does not sufficiently define the return values for the following methods

      • getSupportedExtensions
      • getSupportedControls
      • getSupportedFeatures

      Do they return the OIDs, or a name, or a description (what language)?
      The implementation
      org.apache.directory.ldapstudio.browser.core.internal.model.RootDSE
      for instance replaces OIDs with names from a map file, if they are contained in it. It is therefore not easy to determine whether a given LDAP control etc. is supported or not. I recommend to define that the return values of type String[] always return the OIDs, and a translation into text (if necessary) is due to UI classes only.

        Activity

        Pierre-Arnaud Marcelot made changes -
        Fix Version/s 0.9.0 [ 12312287 ]
        Fix Version/s 1.0.0 [ 12312288 ]
        Stefan Zoerner made changes -
        Resolution Fixed [ 1 ]
        Fix Version/s 0.8.0 [ 12312286 ]
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 0.9.0 [ 12312287 ]
        Hide
        Stefan Zoerner added a comment -

        I have removed the translation from OIDs from the implementing class (will be moved to UI class and changed to a ResourceBundle).

        http://svn.apache.org/viewvc?view=rev&revision=537147
        http://svn.apache.org/viewvc?view=rev&revision=537150

        Show
        Stefan Zoerner added a comment - I have removed the translation from OIDs from the implementing class (will be moved to UI class and changed to a ResourceBundle). http://svn.apache.org/viewvc?view=rev&revision=537147 http://svn.apache.org/viewvc?view=rev&revision=537150
        Stefan Zoerner made changes -
        Field Original Value New Value
        Assignee Stefan Zoerner [ szoerner ]
        Hide
        Stefan Seelmann added a comment -

        Stefan, you are totally right. The interface lacks on documentation and the RootDSE class implementation is bad. Thanks for heads up. As you suggest the best way would be to return the OIDs only. BTW, the methods are only used from the RootDSEPropertyPage.

        Show
        Stefan Seelmann added a comment - Stefan, you are totally right. The interface lacks on documentation and the RootDSE class implementation is bad. Thanks for heads up. As you suggest the best way would be to return the OIDs only. BTW, the methods are only used from the RootDSEPropertyPage.
        Stefan Zoerner created issue -

          People

          • Assignee:
            Stefan Zoerner
            Reporter:
            Stefan Zoerner
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development