[DIRSERVER-91] without equals implementation in Add/Delete stubs tests are invalid

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: pre-1.0
• Fix Version/s: pre-1.0
• Component/s: asn1
• Assignee: Alex Karasulu
• Reporter: Alex Karasulu
• Created: 26/Aug/04 06:02
• Updated: 07/Feb/06 13:29
• Resolved: 26/Aug/04 07:32

Description

I just realized that the tests for add and delete req/resp pairs are using the parent equals() methods from the AbstractMessage base class which only compares the type, controls and message ids of Messages. We need to make sure the req/resp pairs factor in additional attributes while determining equality.

For the responses we can kill two birds with one stone by overriding AbstractMessage.equals() within the AbstractResultResponse. This way we can compare the result properties in one place to determine equality.

The Add and Delete requests are going to need their own equals() overrides within AddRequestImpl and DeleteRequestImpl.

Issue Links

• is depended upon by: DIRSERVER-9 Complete encoder for AddRequest
• is depended upon by: DIRSERVER-21 Complete encoder for AddResponse
• is depended upon by: DIRSERVER-45 Integration test add/del functionality using old eve precursor
• is depended upon by: DIRSERVER-92 Complete encoder for DelResponse