Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5.4
    • Component/s: core
    • Labels:
      None

      Description

      The majority of the code in the ServerContextFactory which is an InitialContextFactory implementation is for firing up the Eve backend subsystem at this point. This is not relavent to what an InitialContextFactory impl should be doing. Yes an InitialContextFactory impl will most likely trigger the firing up of the server but the actually assembly of the backend subsystem is not its concern. What I'm thinking here is creating a factory for assembing the subsystem. This will remove and better isolate this code which is only cluttering up the JNDI provider at the present moment.

        Activity

        Error rendering 'com.atlassian.jirafisheyeplugin:fisheye-issuepanel'. Please contact your JIRA administrators.

        Alex Karasulu made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Hide
        Alex Karasulu added a comment -

        Yep this is all done now. The Contexts in the core-jndi provider will just wrap the DirectoryService which is provided in the constructor to a context.

        Show
        Alex Karasulu added a comment - Yep this is all done now. The Contexts in the core-jndi provider will just wrap the DirectoryService which is provided in the constructor to a context.
        Emmanuel Lecharny made changes -
        Fix Version/s 1.5.4 [ 12313147 ]
        Hide
        Emmanuel Lecharny added a comment -

        Part of the bigbang cleanup I guess

        Show
        Emmanuel Lecharny added a comment - Part of the bigbang cleanup I guess
        Alex Karasulu made changes -
        Component/s core [ 12310713 ]
        Alex Karasulu made changes -
        Component/s jndi-provider [ 11088 ]
        Project Directory Server [ 10516 ] Directory ApacheDS [ 12310260 ]
        Key DIREVE-114 DIRSERVER-557
        Hide
        Alex Karasulu added a comment -

        Need a builder pattern i guess rather a factory.

        Show
        Alex Karasulu added a comment - Need a builder pattern i guess rather a factory.
        Alex Karasulu made changes -
        Field Original Value New Value
        Priority Major [ 3 ] Minor [ 4 ]
        Description The majority of the code in the EveContextFactory which is an InitialContextFactory implementation is for firing up the Eve backend subsystem at this point. This is not relavent to what an InitialContextFactory impl should be doing. Yes an InitialContextFactory impl will most likely trigger the firing up of the server but the actually assembly of the backend subsystem is not its concern. What I'm thinking here is creating a factory for assembing the Eve subsystem similar to the one we have for the frontend. This will remove and better isolate this code which is only cluttering up the JNDI provider at the present moment. The majority of the code in the ServerContextFactory which is an InitialContextFactory implementation is for firing up the Eve backend subsystem at this point. This is not relavent to what an InitialContextFactory impl should be doing. Yes an InitialContextFactory impl will most likely trigger the firing up of the server but the actually assembly of the backend subsystem is not its concern. What I'm thinking here is creating a factory for assembing the subsystem. This will remove and better isolate this code which is only cluttering up the JNDI provider at the present moment.
        Summary Do we need an Eve backend factory? Create a partition factory?
        Component/s jndi-provider [ 11088 ]
        Alex Karasulu created issue -

          People

          • Assignee:
            Alex Karasulu
            Reporter:
            Alex Karasulu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development