[DIRSERVER-2270] Inconsistent log level practices

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0.AM25
• Fix Version/s: 2.0.0.AM26
• Component/s: code quality
• Labels: easyfix
• Assignee: Unassigned
• Reporter: Anuhan Torgonshar
• Created: 01/Apr/19 11:04
• Updated: 28/Jun/19 11:26
• Resolved: 28/Jun/19 11:26

Description

Hi, 
I found there are inconsistent log level practices in the Qpid project, and we suspect the following practice should be fixed.
The detail code as well as the modification suggestion are shown below.

problematic logging practice:
====================DefaultDirectoryServiceFactory.java==================
file path: apacheds-parent-2.0.0.AM25\core-annotations\src\main\java\org\apache\directory\server\core\factory\DefaultDirectoryServiceFactory.java
logging statement line: 151
modification suggestion: change log level to ERROR

145 try
146 {
147     FileUtils.deleteDirectory( instanceLayout.getInstanceDirecto ry() );
148 }
149 catch ( IOException e )
150 {
151     LOG.warn( "couldn't delete the instance directory before ini tializing the DirectoryService", e );
152 }

similar code snippet:
====================IntegrationUtils.java================================
file path: apacheds-parent-2.0.0.AM25\core-integ\src\main\java\org\apache\directory\server\core\integ\IntegrationUtils.java
logging statement line: 91

85 try
86 {
87      FileUtils.deleteDirectory( wkdir );
88 }
89 catch ( IOException e )
90 {
91      LOG.error( I18n.err( I18n.ERR_115 ), e );
92 }

We will highly appreciate your feedback!