[DIRSERVER-1950] Unsafe cast to int in getPwdTimeBeforeExpiry calculation of AuthenticationInterceptor

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-M15
• Component/s: core
• Assignee: Unassigned
• Reporter: lucas theisen
• Created: 23/Jan/14 19:45
• Updated: 30/Jan/14 04:34
• Resolved: 28/Jan/14 00:19

Description

int pwdAge = ( int ) ( currentTime - changedTime ) / 1000;

Will cast to int before the division which causes overflow of int if the difference is too large. Even with division, it could still be too large so it is unsafe to use an int value for pwdAge. As it is only used for comparison, we can leave it as a long.