[DIRSERVER-1916] Don't drop 'top' from ObjectClass index, it's never present in the BTree

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-M15
• Fix Version/s: 2.0.0.AM26
• Component/s: backend
• Assignee: Unassigned
• Reporter: Emmanuel Lécharny
• Created: 12/Nov/13 17:58
• Updated: 14/Jun/19 23:14
• Resolved: 14/Jun/19 23:14

Description

There is no need to call the partition specific code to drop the 'top' ObjectClass, it's not managed by any index. The following code in AbstractBTreePartition need to be changed :

            // Update the ObjectClass index
            for ( Value<?> value : objectClass )
            {
                objectClassIdx.drop( value.getString(), id );
            }

This is the same thing for modifyAdd() :

            for ( Value<?> value : mods )
            {
                objectClassIdx.add( ( String ) value.getNormValue(), id );
            }

and modifyReplace() :

            for ( Value<?> value : entry.get( OBJECT_CLASS_AT ) )
            {
                objectClassIdx.drop( ( String ) value.getNormValue(), id );
            }

for modifyRemove() :

                for ( Value<?> objectClass : entry.get( OBJECT_CLASS_AT ) )
                {
                    objectClassIdx.drop( ( String ) objectClass.getNormValue(), id );
                }

and

                for ( Value<?> value : mods )
                {
                    objectClassIdx.drop( ( String ) value.getNormValue(), id );
                }