Directory ApacheDS
  1. Directory ApacheDS
  2. DIRSERVER-1659

the apacheds.sh/bat files contains a hard coded revision. This is not good

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-M3
    • Fix Version/s: 2.0.0-M8
    • Component/s: None
    • Labels:
      None

      Description

      Currently, we have hard coded the revision in the two batch files (service/apacheds.sh/bat).

      When we cut a release, we will likely forget to change those versions. They should be generated while we process the release, before we push the files to the tags directory.

      I don't know if it's possible though...

        Activity

        Emmanuel Lecharny created issue -
        Hide
        Pierre-Arnaud Marcelot added a comment -

        I agree we should try to have them generated instead of managing them by hand before and after each version change.

        We could move them to 'src/main/resources' and have them filtered with the correct version by Maven during the build.
        However, we won't have them anymore at the root of the 'service' project and we'll need to look at the filtered version in the target directory (nothing too complicated though).

        Show
        Pierre-Arnaud Marcelot added a comment - I agree we should try to have them generated instead of managing them by hand before and after each version change. We could move them to 'src/main/resources' and have them filtered with the correct version by Maven during the build. However, we won't have them anymore at the root of the 'service' project and we'll need to look at the filtered version in the target directory (nothing too complicated though).
        Pierre-Arnaud Marcelot made changes -
        Field Original Value New Value
        Fix Version/s 2.0.0-M5 [ 12319508 ]
        Fix Version/s 2.0.0-M4 [ 12317861 ]
        Pierre-Arnaud Marcelot made changes -
        Fix Version/s 2.0.0-M6 [ 12319540 ]
        Fix Version/s 2.0.0-M5 [ 12319508 ]
        Pierre-Arnaud Marcelot made changes -
        Fix Version/s 2.0.0-M6 [ 12319540 ]
        Fix Version/s 2.0.0-M7 [ 12320049 ]
        Hide
        Kiran Ayyagari added a comment -

        so I ask this, should we keep the version number in the artifact's name? If we can drop that(using <finalName> in pom) this will be easy to solve.

        Show
        Kiran Ayyagari added a comment - so I ask this, should we keep the version number in the artifact's name? If we can drop that(using <finalName> in pom) this will be easy to solve.
        Hide
        Emmanuel Lecharny added a comment -
        Show
        Emmanuel Lecharny added a comment - Pierre-Arnaud suggestion is good. See http://maven.apache.org/plugins/maven-resources-plugin/examples/filter.html
        Hide
        Kiran Ayyagari added a comment -

        yeah, but am looking for an option to not move the current location(if possible) of the .sh and .bat files.

        Show
        Kiran Ayyagari added a comment - yeah, but am looking for an option to not move the current location(if possible) of the .sh and .bat files.
        Emmanuel Lecharny made changes -
        Fix Version/s 2.0.0-M8 [ 12320058 ]
        Hide
        Emmanuel Lecharny added a comment -

        Fixed in the shell script for linux. No idea how to fix it for windows...

        Show
        Emmanuel Lecharny added a comment - Fixed in the shell script for linux. No idea how to fix it for windows...
        Emmanuel Lecharny made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.0.0-M7 [ 12320049 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Emmanuel Lecharny
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development