Directory ApacheDS
  1. Directory ApacheDS
  2. DIRSERVER-1346

Use ServiceLifecycleListener to avoid having System.out messages for service start/stop events.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.5.4
    • Fix Version/s: 2.0.0-M13
    • Component/s: None
    • Labels:
      None

      Description

      In the following commit a number of System.out lines were added to various ApacheDS services:

      http://svn.apache.org/viewvc?view=rev&revision=696371

      I understand that this was done to facilitate Studio's server log which displays the starting and stopping of various services. The problem with this is that is generates a lot of output clutter during test that are run when building the project. Sometimes one feels as though the test failed since they're used to the old format. I don't think this information is that worth while to have on the command line but it it does make sense in Studio's log view.

      Fixing this is simple. We can create a basic ServiceListener interface which contains the start() and stop() methods. The services can then have some code to notify registered listeners. Then an implementation can be created to just print out these status messages to the console when the services are being used in Studio.

      1. DIRSERVER-1346.patch
        13 kB
        Andrea A.A. Gariboldi

        Activity

        Emmanuel Lecharny made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Emmanuel Lecharny made changes -
        Fix Version/s 2.0.0-M13 [ 12324631 ]
        Fix Version/s 2.0.0-RC1 [ 12313387 ]
        Emmanuel Lecharny made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Pierre-Arnaud Marcelot made changes -
        Fix Version/s 2.0.0-RC1 [ 12313387 ]
        Fix Version/s 2.0.0-M3 [ 12316467 ]
        Pierre-Arnaud Marcelot made changes -
        Fix Version/s 2.0.0-M3 [ 12316467 ]
        Fix Version/s 2.0.0-M2 [ 12316056 ]
        Pierre-Arnaud Marcelot made changes -
        Fix Version/s 2.0.0-M2 [ 12316056 ]
        Fix Version/s 2.0.0-M1 [ 12316055 ]
        Emmanuel Lecharny made changes -
        Fix Version/s 2.0-M1 [ 12316055 ]
        Fix Version/s 2.0.0-RC1 [ 12313387 ]
        Emmanuel Lecharny made changes -
        Fix Version/s 2.0.0-RC1 [ 12313387 ]
        Fix Version/s 1.5.5 [ 12313148 ]
        Andrea A.A. Gariboldi made changes -
        Field Original Value New Value
        Attachment DIRSERVER-1346.patch [ 12405546 ]
        Alex Karasulu created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Alex Karasulu
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development