Directory ApacheDS
  1. Directory ApacheDS
  2. DIRSERVER-1346

Use ServiceLifecycleListener to avoid having System.out messages for service start/stop events.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.5.4
    • Fix Version/s: 2.0.0-M13
    • Component/s: None
    • Labels:
      None

      Description

      In the following commit a number of System.out lines were added to various ApacheDS services:

      http://svn.apache.org/viewvc?view=rev&revision=696371

      I understand that this was done to facilitate Studio's server log which displays the starting and stopping of various services. The problem with this is that is generates a lot of output clutter during test that are run when building the project. Sometimes one feels as though the test failed since they're used to the old format. I don't think this information is that worth while to have on the command line but it it does make sense in Studio's log view.

      Fixing this is simple. We can create a basic ServiceListener interface which contains the start() and stop() methods. The services can then have some code to notify registered listeners. Then an implementation can be created to just print out these status messages to the console when the services are being used in Studio.

      1. DIRSERVER-1346.patch
        13 kB
        Andrea A.A. Gariboldi

        Activity

        Hide
        Andrea A.A. Gariboldi added a comment -

        proposed patch

        Show
        Andrea A.A. Gariboldi added a comment - proposed patch
        Hide
        Emmanuel Lecharny added a comment -

        I tried to apply the patch, but the ServiceListener class is missing ...

        Show
        Emmanuel Lecharny added a comment - I tried to apply the patch, but the ServiceListener class is missing ...
        Hide
        Emmanuel Lecharny added a comment -

        Postponed to 2.0.0-RC1

        Show
        Emmanuel Lecharny added a comment - Postponed to 2.0.0-RC1
        Hide
        Pierre-Arnaud Marcelot added a comment -

        Version 2.0.0-M1 has been released.
        Moving all related non-resolved issues to the next version.

        Show
        Pierre-Arnaud Marcelot added a comment - Version 2.0.0-M1 has been released. Moving all related non-resolved issues to the next version.
        Hide
        Pierre-Arnaud Marcelot added a comment -

        Version 2.0.0-M3 has been released a couple months ago.

        Assigned the remaining opened JIRA to the next iteration (2.0.0-M4).

        Show
        Pierre-Arnaud Marcelot added a comment - Version 2.0.0-M3 has been released a couple months ago. Assigned the remaining opened JIRA to the next iteration (2.0.0-M4).
        Hide
        Emmanuel Lecharny added a comment -

        The System.out.println have been removed a long time ago

        Show
        Emmanuel Lecharny added a comment - The System.out.println have been removed a long time ago

          People

          • Assignee:
            Unassigned
            Reporter:
            Alex Karasulu
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development