[DIRSERVER-1313] Potential NPEs while loading LDIFs in unit tests

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.4
• Fix Version/s: 1.5.5
• Component/s: core-integ
• Assignee: Emmanuel Lécharny
• Reporter: Pierre-Arnaud Marcelot
• Created: 23/Feb/09 08:48
• Updated: 23/Feb/09 10:49
• Resolved: 23/Feb/09 10:36

Description

There are potential NPEs while loading LDIFs in unit tests.

Class: org.apache.directory.server.core.integ.state.AbstractState
Method: protected void injectLdifs( DirectoryService service, InheritableSettings settings )
Lines 195 to 198.
[...]
Class<?> clazz = Class.forName( className );
URL url = clazz.getResource( ldifFile );
URI uri = url.toURI();
File file = new File( uri );
[...]

There are no check here to see either the 'clazz', 'url', 'uri' or 'file' variables are null.
If one of them is null, we'll get a NPE.