[DIRSERVER-1093] the ResourceRecordEncoder and QuestionRecordEncoder have bug for empty domainName:(

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.1
• Fix Version/s: 2.0.0-M7
• Component/s: dns
• Environment: Windows XP , apacheds-protocol-dns-1.5.1.jar
• Assignee: Enrique Rodriguez
• Reporter: lizongbo
• Created: 31/Oct/07 09:31
• Updated: 15/Aug/13 01:21
• Resolved: 28/Feb/12 02:19

Description

When I use dig trace for Test the apache dns server. the QuestionRecord and ResourceRecord not encoded right for the empty Domain Name.

my Test command is:

E:\bind>dig @10.108.20.126 618119.com +trace

Then found this bug is caeused by the method "encodeDomainName" in QuestionRecordEncoder.java and "putDomainName" in ResourceRecordEncoder.java.

follow code can be test to get "labels.length == 1";

[code]
String s = "";
String[] labels = new String[0];
labels = s.split("
.");
System.out.println("labels.length == " + labels.length);
[/code]

so i fix this bug by follow change :

[code]
String[] labels = domainName.split( "
." );
[/code]

change to:

[code]
String[] labels = new String[0];
if (domainName != null && domainName.length() > 0)

{ labels = domainName.split("\\."); }

[/code]

Please fix the bug