Details

    • Type: Sub-task Sub-task
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 3.0.0-M2
    • Fix Version/s: 3.0.0-trunk
    • Component/s: None
    • Labels:
      None

      Activity

      Julien Vermillard created issue -
      Julien Vermillard made changes -
      Field Original Value New Value
      Priority Blocker [ 1 ] Major [ 3 ]
      Hide
      Arnaud Bourrée added a comment -

      Why HttpServerEncoder and HttpServerDecoder classes have dependencies on com.google.common.base.Charsets?
      I'm newbie on Google API, but after reading JavaDoc, it looks that two constants used in mina-http are shortcut to java.nio.charset.Charset.forName().
      And I don't see any other dependency on.
      So do we really need Google API?

      Arnaud.

      Show
      Arnaud Bourrée added a comment - Why HttpServerEncoder and HttpServerDecoder classes have dependencies on com.google.common.base.Charsets? I'm newbie on Google API, but after reading JavaDoc, it looks that two constants used in mina-http are shortcut to java.nio.charset.Charset.forName(). And I don't see any other dependency on. So do we really need Google API? Arnaud.
      Hide
      Julien Vermillard added a comment -

      Yes you are right, we need to remove the dependence to guava. It's there because the code is based on deft : http://incubator.apache.org/deft/

      Show
      Julien Vermillard added a comment - Yes you are right, we need to remove the dependence to guava. It's there because the code is based on deft : http://incubator.apache.org/deft/
      Hide
      Julien Vermillard added a comment -

      I just removed the guava dependency, thanks for the catch

      Show
      Julien Vermillard added a comment - I just removed the guava dependency, thanks for the catch
      Emmanuel Lecharny made changes -
      Affects Version/s 3.0.0-trunk [ 12319285 ]
      Hide
      Ashish Paliwal added a comment -

      Does our http module covers this requirement?

      Show
      Ashish Paliwal added a comment - Does our http module covers this requirement?
      Julien Vermillard made changes -
      Fix Version/s 3.0.0-trunk [ 12319285 ]
      Fix Version/s 3.0.0-M1 [ 12313531 ]
      Julien Vermillard made changes -
      Fix Version/s 3.0.0-trunk [ 12324821 ]
      Fix Version/s 3.0.0-M2 [ 12319285 ]

        People

        • Assignee:
          Unassigned
          Reporter:
          Julien Vermillard
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:

            Development