Uploaded image for project: 'MINA'
  1. MINA
  2. DIRMINA-845

ProtocolEncoderOutputImpl isn't thread-safe

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 2.0.4
    • Fix Version/s: 2.0.8
    • Component/s: Filter
    • Labels:
      None

      Description

      ProtocolEncoderOutputImpl uses ConcurrentLinkedQueue and at first look it seems to be thread-safe. But really concurrent execution of flush method isn't thread-safe (and write-mergeAll also).

      E.g. in RTMP several channels multiplexed in single connection. According protocol specification it's possible to write to different channels concurrently. But it doesn't work with MINA.
      I've synchronized channel writing, but it doesn't prevent concurrent run of flushing (in 2.0.4 it's done directly in ProtocolCodecFilter.filterWrite, but ProtocolEncoderOutputImpl.flush has the same problem).

      Here the fragment of flushing code:

      while (!bufferQueue.isEmpty()) {
        Object encodedMessage = bufferQueue.poll();
                      
        if (encodedMessage == null) {
          break;
        }
      
        // Flush only when the buffer has remaining.
        if (!(encodedMessage instanceof IoBuffer) || ((IoBuffer) encodedMessage).hasRemaining()) {
          SocketAddress destination = writeRequest.getDestination();
          WriteRequest encodedWriteRequest = new EncodedWriteRequest(encodedMessage, null, destination); 
      
          nextFilter.filterWrite(session, encodedWriteRequest);
        }
      } 
      

      Suppose original packets sequence is A, B, ...
      Concurrent run of flushing may proceed as following:

      thread-1: Object encodedMessage = bufferQueue.poll(); // gets A packet
      thread-2: Object encodedMessage = bufferQueue.poll(); // gets B packet
      ...
      thread-2: nextFilter.filterWrite(...); // writes B packet
      thread-1: nextFilter.filterWrite(...); // writes A packet

      so, resulting sequence will B, A

      It's quite confusing result especially when documentation doesn't contain any explanation about such behavior.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              ilya.a.ivanov Ilya Ivanov
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: