[DIRMINA-840] Logic Error in ByteArrayPool implementation

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.4
• Fix Version/s: 2.0.5
• Component/s: Core
• Assignee: Unassigned
• Reporter: Fei Wang
• Created: 23/Jun/11 03:01
• Updated: 09/Jul/12 12:26
• Resolved: 09/Jul/12 12:01

Description

The is some logical error in ByteArrayPool#create(int size).

The two lines below should be changed to
if (!freeBuffers.isEmpty()) {
DirectBufferByteArray ba = freeBuffers.get(bits).pop();

if (!freeBuffers.get(bits).isEmpty()) {
DirectBufferByteArray ba = freeBuffers.get(bits).pop();