[DIRMINA-719] Serial Filter Chain Broken For Outbound Data

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-M4, 2.0.0-M6
• Fix Version/s: 2.0.0-RC1
• Component/s: Transport
• Environment: Linux & Windows, serial-transport only
• Assignee: Julien Vermillard
• Reporter: boB Gage
• Created: 18/Jun/09 13:40
• Updated: 19/Oct/09 20:15
• Resolved: 18/Aug/09 15:37

Description

IoFilterAdapter-descended filter's messageSent() hook called only with 0-byte (Mina internal indicator, I'm told) IoBuffer data, not with IoBuffer containing data actually sent out the serial port.

Filter object looks like:

public class CaptureLogFilter extends IoFilterAdapter {
...
   @Override
   public void messageReceived(NextFilter nextFilter, IoSession
session, Object message) throws Exception {
       log("RECEIVED: ", message);
       if (nextFilter != null ) nextFilter.messageReceived(session,
message);
   }

   @Override
   public void messageSent(NextFilter nextFilter, IoSession session,
WriteRequest writeRequest) throws Exception {
       log("SENT: ", writeRequest.getMessage());
       if (nextFilter != null ) nextFilter.messageSent(session,
writeRequest);
   }
...
   private void log(String event, Object arg) {
       if (arg != null && arg instanceof IoBuffer) {
           byte b[] = IoBufferUtils.asBytes((IoBuffer) arg);
           log(event + b.length + " bytes: " + ByteUtils.toHex(b));
//            IoBuffer i = (IoBuffer)arg;
//            log("DBG: " + event + "pos: " + i.position() + ", lim:
"+i.limit());
// Previous debug was added to confirm IoBufferUtils operation, the IoBuffer 'arg' is confirmed empty (both position & limit are 0)
       }
       else log(event);
   }
...
}

And is hooked in the IoConnector set up:

   private final IoConnector buildIoConnector() {
...
       if ( codecFilter == null )
           codecFilter = new ProtocolCodecFilter(createCodecFactory());
...
       DefaultIoFilterChainBuilder fc = connector.getFilterChain();
       if ( fc.contains("logging") ) fc.remove("logging");
       if ( fc.contains("codec") ) fc.remove("codec");
       fc.addLast("logging", new
CaptureLogFilter(getClass().getSimpleName()));
       fc.addLast("codec", codecFilter);
...
}