[DIRMINA-671] AbstractPollingIoProcessor

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: 2.0.0-M4
• Fix Version/s: 2.0.6
• Component/s: Core
• Assignee: Unassigned
• Reporter: Aaron Wald
• Created: 12/Mar/09 17:57
• Updated: 10/Jul/12 15:42
• Resolved: 10/Jul/12 15:42

Description

In flushNow() it appears to me that when writeBuffer is called, when the buffer is completely sent, we will always come into the buffer isn't empty check.

if (message instanceof IoBuffer) {
localWrittenBytes = writeBuffer(
session, req, hasFragmentation,
maxWrittenBytes - writtenBytes,
currentTime);
if (localWrittenBytes > 0 && ((IoBuffer)message).hasRemaining() )

{ // the buffer isn't empty, we re-interest it in writing writtenBytes += localWrittenBytes; setInterestedInWrite(session, true); return false; }

}

In writeBuffer this is done:
if (!buf.hasRemaining() ||
!hasFragmentation && localWrittenBytes != 0)

{ // Buffer has been sent, clear the current request. buf.reset(); fireMessageSent(session, req); }

fireMessageSent clears the write request, so when we come back after select() we wont double send data but it seems like twice the work is being done.