[DIRMINA-629] The IoServiceStatistics methods are called for every new session creation

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0-M3
• Fix Version/s: 2.0.8
• Assignee: Unassigned
• Reporter: Emmanuel Lécharny
• Created: 12/Oct/08 10:50
• Updated: 03/Dec/21 08:06
• Resolved: 06/Sep/14 20:27

Description

When a session is established, some methods of the IoServiceStatistics class are called :

protected final void finishSessionInitialization(IoSession session, IoFuture future, IoSessionInitializer sessionInitializer) {
if (stats.getLastReadTime() == 0) {
((IoServiceStatistics)stats).setLastReadTime(getActivationTime());

There are two problems with this approach :

• first, many of the members of this classes are not thread safe, leading to some random value potentially be put into the stats instance for the service
• second, if we protect those members using some synchronization (or volatile data), it might slow down the connection initialization.

The IoServiceStatistics class should be thread safe, and these statistics should not be updated if the user don't want them, ie, it should be optionnal (the Configuration object should take care of this)

Issue Links

• is related to: DIRMINA-1152 IoServiceStatistics introduces huge latencies
• relates to: DIRMINA-585 Visibility issue in various configuration properties and a few critical counters.