[DIRMINA-620] IoSession has superfluous close() methods

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0-M1, 2.0.0-M2, 2.0.0-M3
• Fix Version/s: 2.0.0-M4
• Component/s: Core
• Assignee: Unassigned
• Reporter: Tuure Laurinolli
• Created: 05/Sep/08 14:01
• Updated: 07/Jun/09 07:54
• Resolved: 14/Nov/08 09:41

Description

IoSession has three methods for closing the session: close() which closes immediately, closeOnFlush(), which closes after last queued write is complete and close(boolean) which can be set to do either.

The two first variants should be removed and close(boolean) retained to make the API cleaner. Also, having a single close(boolean) method forces the user to think about the issue of closing immediately versus closing after last queued write.