[DIRMINA-307] ReadThrottleFilterBuilder does not resume reading.

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.0.1
• Component/s: Filter
• Assignee: Trustin Lee
• Reporter: Martin Ritchie
• Created: 15/Nov/06 14:27
• Updated: 28/Nov/06 11:57
• Resolved: 28/Nov/06 01:03

Description

The starvation problems being experienced by testing of the MultiThreadedSocketIOProcessor(DIRMINA-301) are related to this bug.

When using multiple threads the the removeal of attribute SUSPENDED_READS is not done after resuming reads it is done on any and all calls to release.

The session.removeAttribute( SUSPENDED_READS ); line should be moved inside the if statement.

in method release:

if( counter < maximumConnectionBufferSize && isSuspendedReads( session ) )

{ session.resumeRead(); session.removeAttribute( SUSPENDED_READS ); }

Patch is attached.